Define cirq.ISWAP_INV #4624
Closed
Define cirq.ISWAP_INV #4624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unaiic
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
dabacon
approved these changes
Nov 7, 2021
| (cirq.ISWAP ** -0.5, np.pi / 4, 0), | ||
| (cirq.ISWAP ** 1.0, -np.pi / 2, 0), | ||
| (cirq.ISWAP ** -1.0, np.pi / 2, 0), | ||
| (cirq.ISWAP_INV, np.pi / 2, 0), |
Collaborator
There was a problem hiding this comment.
nit: move down below other ISWAP. Also considering adding another case like cirq.ISWAP_INV ** 0.5
tanujkhattar
requested changes
Nov 8, 2021
Collaborator
There was a problem hiding this comment.
Please create cirq-core/cirq/protocols/json_test_data/ISWAP_INV.json and cirq-core/cirq/protocols/json_test_data/ISWAP_INV.repr to fix the failing tests. You can look at existing json and repr files for ISWAP for reference.
Please also add tests to cirq-core/cirq/ops/swap_gates_test.py by extending the existing tests for cirq.SWAP.
Collaborator
|
@unaiic Gentle reminder. Please address the comments and fix the failing tests so that we can merge the PR. |
Merged
Collaborator
|
Implemented in #5613 |
CirqBot
pushed a commit
that referenced
this pull request
Jun 25, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fixes quantumlib#4615 quantumlib#4624 has not been touched in a long time, so jumping in to fix this.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Fixes quantumlib#4615 quantumlib#4624 has not been touched in a long time, so jumping in to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a global constant for
cirq.ISWAP_INV, similar tocirq.SQRT_ISWAP_INV, and replace usages ofcirq.ISWAP ** -1withcirq.ISWAP_INV.Fixes #4615.