Skip to content

Conversation

@dabacon
Copy link
Collaborator

@dabacon dabacon commented Jun 24, 2022

Fixes #4615

#4624 has not been touched in a long time, so jumping in to fix this.

@dabacon dabacon requested review from a team, cduck, verult, vtomole and wcourtney as code owners June 24, 2022 22:34
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 24, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after typo fix

This module creates Gate instances for the following gates:
SWAP: the swap gate.
ISWAP: a swap gate with a phase on the swapped subspace.
ISWAP_SQRT: the inverse of the ISWAP gate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INV

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MichaelBroughton MichaelBroughton self-assigned this Jun 24, 2022
@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 24, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 25, 2022
@dabacon dabacon mentioned this pull request Jun 25, 2022
@CirqBot CirqBot merged commit 3c8927b into quantumlib:master Jun 25, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 25, 2022
@dabacon dabacon mentioned this pull request Jun 25, 2022
CirqBot pushed a commit that referenced this pull request Jun 25, 2022
Had to wait for #5613 to be done before adding to zoo (chicken, meet egg.  Egg, chicken)
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Fixes quantumlib#4615

quantumlib#4624 has not been touched in a long time, so jumping in to fix this.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Had to wait for quantumlib#5613 to be done before adding to zoo (chicken, meet egg.  Egg, chicken)
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Fixes quantumlib#4615

quantumlib#4624 has not been touched in a long time, so jumping in to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define cirq.ISWAP_INV, similar to cirq.SQRT_ISWAP_INV and replace usages.

3 participants