[cirqflow] Hardcoded qubit placement #5194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mpharrigan
force-pushed
the
2022-01-qubit-placement-c
branch
from
cf5e14f to
051733c
Compare
mpharrigan
force-pushed
the
2022-01-qubit-placement-c
branch
from
051733c to
284cbb7
Compare
mpharrigan
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
tanujkhattar
requested changes
Apr 19, 2022
Collaborator
tanujkhattar
left a comment
tanujkhattar
left a comment
There was a problem hiding this comment.
Looking good overall. Left a first round of comments.
| max_plots: int = 20, | ||
| axes: Sequence[plt.Axes] = None, | ||
| tilted=True, | ||
| bad_placement_callback=None, |
Collaborator
There was a problem hiding this comment.
nit: Add type annotation (preferably also to the tilted argument above)
|
|
||
|
|
||
| class HardcodedQubitPlacer(QubitPlacer): | ||
| def __init__( |
Collaborator
There was a problem hiding this comment.
nit: Add docstrings to the class, init and other public methods like place_circuit (if the inherited docstring is not enough).
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Collaborator
Author
|
@tanujkhattar ptal |
mpharrigan
added
the
automerge
Collaborator
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
mpharrigan
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Apr 22, 2022
Add a `QubitPlacer` that takes an explicit mapping in its constructor.
Closed
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Add a `QubitPlacer` that takes an explicit mapping in its constructor.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Add a `QubitPlacer` that takes an explicit mapping in its constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
QubitPlacerthat takes an explicit mapping in its constructor.