Fix default QuantumStateRepresentation sampler for qudits #5234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@95-martin-orion small one here if you missed it. |
95-martin-orion
approved these changes
Apr 22, 2022
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Apr 22, 2022
…#5234) Now that there's a default sample method for QuantumStateRepr, I updated a test function to use that instead (by removing the custom implementation that test used previously). The test below started to fail (it returned `[[1], [1]]` even though all breakpoints showed that the measurement was still `[[2], [2]]`, which was *super* confusing). I finally tracked it down to the dtype being `bool` in that default `sample` method. Changed that to uint8, and now all tests pass using the default sampler. I didn't add any new tests because the changes to the existing test validates it. https://github.com/quantumlib/Cirq/blob/1522b024d2613b9acd0a57ca9eafa58371063484/cirq-core/cirq/sim/simulator_base_test.py#L237-L240 Also piggybacked a small todo from one of my other tests into this PR.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…#5234) Now that there's a default sample method for QuantumStateRepr, I updated a test function to use that instead (by removing the custom implementation that test used previously). The test below started to fail (it returned `[[1], [1]]` even though all breakpoints showed that the measurement was still `[[2], [2]]`, which was *super* confusing). I finally tracked it down to the dtype being `bool` in that default `sample` method. Changed that to uint8, and now all tests pass using the default sampler. I didn't add any new tests because the changes to the existing test validates it. https://github.com/quantumlib/Cirq/blob/1522b024d2613b9acd0a57ca9eafa58371063484/cirq-core/cirq/sim/simulator_base_test.py#L237-L240 Also piggybacked a small todo from one of my other tests into this PR.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…#5234) Now that there's a default sample method for QuantumStateRepr, I updated a test function to use that instead (by removing the custom implementation that test used previously). The test below started to fail (it returned `[[1], [1]]` even though all breakpoints showed that the measurement was still `[[2], [2]]`, which was *super* confusing). I finally tracked it down to the dtype being `bool` in that default `sample` method. Changed that to uint8, and now all tests pass using the default sampler. I didn't add any new tests because the changes to the existing test validates it. https://github.com/quantumlib/Cirq/blob/1522b024d2613b9acd0a57ca9eafa58371063484/cirq-core/cirq/sim/simulator_base_test.py#L237-L240 Also piggybacked a small todo from one of my other tests into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there's a default sample method for QuantumStateRepr, I updated a test function to use that instead (by removing the custom implementation that test used previously). The test below started to fail (it returned
[[1], [1]]even though all breakpoints showed that the measurement was still[[2], [2]], which was super confusing). I finally tracked it down to the dtype beingboolin that defaultsamplemethod. Changed that to uint8, and now all tests pass using the default sampler. I didn't add any new tests because the changes to the existing test validates it.Cirq/cirq-core/cirq/sim/simulator_base_test.py
Lines 237 to 240 in 1522b02
Also piggybacked a small todo from one of my other tests into this PR.