Skip to content

Conversation

@daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Apr 22, 2022

Removes the simulator package dependency on ActOnArgs, freeing up other simulators to implement SimulatesIntermediateState without needing specifically to implement ActOnArgs. @95-martin-orion

@daxfohl daxfohl requested review from a team, cduck and vtomole as code owners April 22, 2022 23:43
@daxfohl daxfohl requested a review from 95-martin-orion April 22, 2022 23:43
@CirqBot CirqBot added the size: S 10< lines changed <50 label Apr 22, 2022
@daxfohl daxfohl marked this pull request as draft April 23, 2022 00:13
@daxfohl daxfohl marked this pull request as ready for review April 23, 2022 05:04
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 25, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 25, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Apr 25, 2022

Automerge cancelled: A required status check is not present.

Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 25, 2022
@95-martin-orion 95-martin-orion merged commit 42f0ee1 into quantumlib:master Apr 25, 2022
@daxfohl daxfohl deleted the sim-state-qubit-map branch April 26, 2022 14:18
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
quantumlib#5283)

* Bump types so that SimulatesIntermediateState isn't bound to ActOnArgs

* Fix StepResult initializer types to match TrialResult

* docstring

* coverage

Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
quantumlib#5283)

* Bump types so that SimulatesIntermediateState isn't bound to ActOnArgs

* Fix StepResult initializer types to match TrialResult

* docstring

* coverage

Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants