Skip to content

Avoid subshell executions for $(pwd) #5436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2022
Merged

Avoid subshell executions for $(pwd) #5436

merged 3 commits into from
Jun 2, 2022

Conversation

@pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Jun 2, 2022

No need to start subshell, $PWD has already the same value.

@pavoljuhas pavoljuhas requested review from a team, cduck and vtomole as code owners June 2, 2022 17:27
@pavoljuhas pavoljuhas requested a review from viathor June 2, 2022 17:27
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 2, 2022
MichaelBroughton
MichaelBroughton approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Jun 2, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 2, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 2, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jun 2, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 2, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 2, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 2, 2022
@CirqBot CirqBot merged commit ac5aa50 into quantumlib:master Jun 2, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 2, 2022
@pavoljuhas pavoljuhas deleted the replace-shell-substitution-pwd branch June 3, 2022 00:59
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Avoid subshell executions for $(pwd) (quantumlib#5436)
a8de5ce 
No need to start subshell, $PWD has already the same value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels

Size: XS <10 lines changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavoljuhas @CirqBot @MichaelBroughton