Skip to content

Avoid subshell executions for $(pwd) #5436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Avoid subshell executions for $(pwd) #5436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bb5ce0
Avoid unnecessary sub-shell calls $(pwd)
pavoljuhas May 27, 2022
7bd54d9
Merge branch 'master' into replace-shell-substitution-pwd
CirqBot Jun 2, 2022
e31bd0a
Merge branch 'master' into replace-shell-substitution-pwd
CirqBot Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ jobs:
run: |
export CIRQ_PRE_RELEASE_VERSION=$(dev_tools/packaging/generate-dev-version-id.sh)
[[ "$CIRQ_PRE_RELEASE_VERSION" =~ .*dev.* ]] && echo "Deploying dev version '$CIRQ_PRE_RELEASE_VERSION'" || (echo "not dev version"; exit 1)
out_dir=$(pwd)/dist
out_dir="${PWD}/dist"
dev_tools/packaging/produce-package.sh ${out_dir} $CIRQ_PRE_RELEASE_VERSION
twine upload "${out_dir}/*"
2 changes: 1 addition & 1 deletion check/build-changed-protos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ else
fi

# All the protos.
echo "Building protos in $(pwd)"
echo "Building protos in $PWD"

dev_tools/build-protos.sh

Expand Down
2 changes: 1 addition & 1 deletion dev_tools/build-protos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ trap "{ echo -e '\033[31mFAILED\033[0m'; }" ERR
cd "$(dirname "${BASH_SOURCE[0]}")"
cd "$(git rev-parse --show-toplevel)"

cd $(pwd)/cirq-google
cd cirq-google || exit $?

# Build protos for each protobuf package.
for package in cirq_google/api/v1 cirq_google/api/v2
Expand Down
2 changes: 1 addition & 1 deletion dev_tools/docs/build-rtd-docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,5 @@ rm -rf "${docs_conf_dir}/generated"

echo
echo Index Page:
echo "file://$(pwd)/${out_dir}/html/index.html"
echo "file://${PWD}/${out_dir}/html/index.html"
echo