-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use new quimb TN string format #5525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
viathor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIR, this is the first time this happened with quimb. I'd consider pinning if it keeps happening and affects us more seriously.
|
Thanks for looking into this, @95-martin-orion. This change will cause tests to fail for people who have older versions of quimb installed locally, which seems less than ideal. I don't think we should be relying on string representations provided by third-party libraries to be stable in our tests. |
This isn't the first time we've done something like this - the usual solution is to announce the change and recommend re-installing Cirq requirements.
This is the cost of allowing MPS to use quimb-based state for its string representation. Some alternatives:
@maffoo, what are your thoughts? I'll hold off on merging until I have your approval. |
|
My preference in order:
|
maffoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so we can merge to unblock CI. We can discuss changes to the tests to avoid relying on stability of quimb strings in the future.
Fixes quantumlib#5524. Based on quantumlib#5525 discussion, we don't need to pin quimb (yet!), but testing exact strings for quimb objects is asking for trouble. This reduces the tests to substring checks, which should be less vulnerable to minor quimb movements (e.g. this passes with both quimb v1.3.0 and v1.4.0).
Fixes quantumlib#5524. Based on quantumlib#5525 discussion, we don't need to pin quimb (yet!), but testing exact strings for quimb objects is asking for trouble. This reduces the tests to substring checks, which should be less vulnerable to minor quimb movements (e.g. this passes with both quimb v1.3.0 and v1.4.0).
Resolves the "tests are failing" part of #5524.