Test substring for quimb objects #5529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
approved these changes
Jun 15, 2022
| assert p.text_pretty == text, f"{p.text_pretty} != {text}" | ||
|
|
||
|
|
||
| def assert_repr_pretty_contains(val: Any, substr: str, cycle: bool = False): |
Contributor
There was a problem hiding this comment.
Might be nice to add a version that does a more general regex match as well:
def assert_repr_pretty_matches(val: Any, pattern: Union[str, re.Pattern], cycle: bool = False):
p = FakePrinter()
val._repr_pretty(p, cycle=cycle)
assert re.match(pattern, p.text_pretty), ...
Collaborator
Author
There was a problem hiding this comment.
I appeal to YAGNI here - if someone needs it, they'll make it.
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Fixes quantumlib#5524. Based on quantumlib#5525 discussion, we don't need to pin quimb (yet!), but testing exact strings for quimb objects is asking for trouble. This reduces the tests to substring checks, which should be less vulnerable to minor quimb movements (e.g. this passes with both quimb v1.3.0 and v1.4.0).
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Fixes quantumlib#5524. Based on quantumlib#5525 discussion, we don't need to pin quimb (yet!), but testing exact strings for quimb objects is asking for trouble. This reduces the tests to substring checks, which should be less vulnerable to minor quimb movements (e.g. this passes with both quimb v1.3.0 and v1.4.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5524.
Based on #5525 discussion, we don't need to pin quimb (yet!), but testing exact strings for quimb objects is asking for trouble. This reduces the tests to substring checks, which should be less vulnerable to minor quimb movements (e.g. this passes with both quimb v1.3.0 and v1.4.0).