RDK-60308 : RFC 1.2.2 release changelog updates by nhanasi · Pull Request #180 · rdkcentral/rfc

nhanasi · 2026-02-16T20:37:16Z

RDK-60308 : RFC 1.2.2 release changelog updates

Disable the AccountID Special validation for RDKB

RDKEMW-12201: Bring RDKEMW-12167 to Develop

RFC 1.2.1 release tag

RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

RDK-60308 [RFC] RDK Coverity Defect Resolution for Device

rebase

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>

Add missing RDK_LOG_FATAL constant to fallback definitions

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

RDKB-63483: RFC Fix L1 Issues with new logger api

RDKEMW-13945 Fix L2 Issue on RFC Component

RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device

github-actions · 2026-02-16T20:37:26Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

3 out of 4 committers have signed the CLA.
✅ (Vismalskumar0)[https://github.com/Vismalskumar0]
✅ (nhanasi)[https://github.com/nhanasi]
✅ (madhubabutt)[https://github.com/madhubabutt]
❌ @Copilot
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

Copilot

Pull request overview

This PR updates the CHANGELOG for RFC version 1.2.2 and includes related code improvements and test fixes. The changes primarily address Coverity defects, L2 test issues, and logging improvements.

Changes:

Added CHANGELOG entries for version 1.2.2 with references to multiple PRs and commits
Improved C++ code with modern initialization patterns, std::move optimizations, and better error handling
Added rdk_debug.h header with fallback RDK logger definitions for builds without the logger library
Updated test fixtures with new account IDs and log file references
Commented out webpa test in run_l2.sh script

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
CHANGELOG.md	Added version 1.2.2 release notes with PR and commit references
rfcMgr/rfc_xconf_handler.cpp	Multiple improvements: string initialization using direct construction, std::move optimizations, errno handling, default case in switch, and RDKB-specific conditional compilation
rfcMgr/rfc_manager.cpp	Replaced old logger initialization with new extended API for non-RDKB builds
rfcMgr/rdk_debug.h	New header file providing fallback definitions for RDK logger when not available
test/functional-tests/tests/test_rfc_unknown_accountid.py	Updated account IDs in test assertions and changed log file reference from RFC_LOG_FILE to LOG_FILE
test/functional-tests/tests/rfc_test_helper.py	Added new LOG_FILE constant pointing to rfcscript.txt.1
run_l2.sh	Commented out webpa test execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-16T20:42:13Z

+		rdk_logger_ext_config_t config = {
+            .pModuleName = RFCMGRLOG,                 /* Module name */
+            .loglevel = RDK_LOG_INFO,                 /* Default log level */
+            .output = RDKLOG_OUTPUT_CONSOLE,          /* Output to console (stdout/stderr) */
+            .format = RDKLOG_FORMAT_WITH_TS,          /* Timestamped format */
+            .pFilePolicy = NULL                       /* Not using file output, so NULL */
+        };
+
+        if (rdk_logger_ext_init(&config) != RDK_SUCCESS) {
+            printf("RFC : ERROR - Extended logger init failed\n");
+        }
+#endif		


Inconsistent indentation: This code block uses tabs for indentation while the surrounding code uses spaces. The indentation style should be consistent throughout the file. Replace tabs with spaces to match the existing style in the file.

Copilot · 2026-02-16T20:42:13Z

+        assert grep_log_file(LOG_FILE, FEATURE_NAME_VALUE), f"Expected '{FEATURE_NAME_VALUE}' in log file."
+        assert grep_log_file(LOG_FILE, RFC_PARAM), f"Expected '{RFC_PARAM}' in log file."
+        assert grep_log_file(LOG_FILE, XCONF_RESP_RECEIVED_ACTID_UNKNOWN), f"Expected '{XCONF_RESP_RECEIVED_ACTID_UNKNOWN}' in log file."
+        assert grep_log_file(LOG_FILE, XCONF_RESP_CMP_MSG), f"Expected '{XCONF_RESP_CMP_MSG}' in log file."
+        assert grep_log_file(LOG_FILE, ACTID_REPLACE_AUTHSERVICE), f"Expected '{ACTID_REPLACE_AUTHSERVICE}' in log file."
+        assert grep_log_file(LOG_FILE, ACTID_UPDATE), f"Expected '{ACTID_UPDATE}' in log file."


Inconsistent log file variable usage: This test file now uses LOG_FILE (which refers to "/opt/logs/rfcscript.txt.1") instead of RFC_LOG_FILE (which refers to "/opt/logs/rfcscript.txt") that is used by all other test files in the test suite. This deviation from the established pattern may cause test failures if the expected log messages are written to rfcscript.txt instead of rfcscript.txt.1. Consider using RFC_LOG_FILE for consistency with the rest of the test suite, unless there's a specific requirement for this test to check a different log file.

Suggested change

assert grep_log_file(LOG_FILE, FEATURE_NAME_VALUE), f"Expected '{FEATURE_NAME_VALUE}' in log file."

assert grep_log_file(LOG_FILE, RFC_PARAM), f"Expected '{RFC_PARAM}' in log file."

assert grep_log_file(LOG_FILE, XCONF_RESP_RECEIVED_ACTID_UNKNOWN), f"Expected '{XCONF_RESP_RECEIVED_ACTID_UNKNOWN}' in log file."

assert grep_log_file(LOG_FILE, XCONF_RESP_CMP_MSG), f"Expected '{XCONF_RESP_CMP_MSG}' in log file."

assert grep_log_file(LOG_FILE, ACTID_REPLACE_AUTHSERVICE), f"Expected '{ACTID_REPLACE_AUTHSERVICE}' in log file."

assert grep_log_file(LOG_FILE, ACTID_UPDATE), f"Expected '{ACTID_UPDATE}' in log file."

assert grep_log_file(RFC_LOG_FILE, FEATURE_NAME_VALUE), f"Expected '{FEATURE_NAME_VALUE}' in log file."

assert grep_log_file(RFC_LOG_FILE, RFC_PARAM), f"Expected '{RFC_PARAM}' in log file."

assert grep_log_file(RFC_LOG_FILE, XCONF_RESP_RECEIVED_ACTID_UNKNOWN), f"Expected '{XCONF_RESP_RECEIVED_ACTID_UNKNOWN}' in log file."

assert grep_log_file(RFC_LOG_FILE, XCONF_RESP_CMP_MSG), f"Expected '{XCONF_RESP_CMP_MSG}' in log file."

assert grep_log_file(RFC_LOG_FILE, ACTID_REPLACE_AUTHSERVICE), f"Expected '{ACTID_REPLACE_AUTHSERVICE}' in log file."

assert grep_log_file(RFC_LOG_FILE, ACTID_UPDATE), f"Expected '{ACTID_UPDATE}' in log file."

Copilot · 2026-02-16T20:42:14Z

-                RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME);
+				if (errno != ENOENT)
+				{
+                RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);


Missing spaces in error message: The error log message is missing spaces in two places: after the closing bracket ']' before 'Failed', and after the comma before 'errno'. It should be "[%s][%d] Failed to remove file %s, errno=%d\n" for consistency with other log messages in the codebase and better readability.

Suggested change

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d] Failed to remove file %s, errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);

Copilot · 2026-02-16T20:42:14Z

+				if (errno != ENOENT)
+				{
+                RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);
+				}


Inconsistent indentation: This code block uses tabs for indentation while the surrounding code uses spaces. The indentation style should be consistent throughout the file. Replace tabs with spaces to match the existing style in the file.

github-actions · 2026-02-16T20:51:38Z

Code Coverage Summary

                             Total:|81.3%   2319|92.5%   134|    -      0

Vismalskumar0 and others added 30 commits January 13, 2026 19:32

Disable the AccountID Special validation for RDKB

13d093e

Disable the AccountID Special validation for RDKB

Merge pull request #149 from rdkcentral/release/1.2.1

7a46a03

RDKEMW-12201: Bring RDKEMW-12167 to Develop

Merge tag '1.2.1' into develop

be731ab

RFC 1.2.1 release tag

Merge branch 'develop' into topic/RDK-60308_2

f9cd083

Merge pull request #147 from rdkcentral/topic/RDK-60308_2

84f22d5

RDK-60308-[tr69hostif, RFC] RDK Coverity Defect Resolution for Device Management

Update rfc_xconf_handler.cpp

a395aee

Update rfcMgr/rfc_xconf_handler.cpp

8aae2d6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rfcMgr/rfc_xconf_handler.cpp

095fcdd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update rfc_xconf_handler.cpp

4d843c1

Update rfc_xconf_handler.cpp

b2b4e56

Update rfcMgr/rfc_xconf_handler.cpp

5b98ab9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fixed the final warnings rfc_xconf_handler.cpp

4e32f18

Update rfc_manager.cpp

1742b0f

Update rfc_manager.cpp

2a23678

Update rfc_manager.cpp

974c2d7

Update rfc_manager.cpp

7f37e75

Update rfc_manager.cpp

f584523

Remove the logger changes

ccf730f

Update rfc_manager.cpp

acb6cfe

Merge pull request #166 from rdkcentral/feature/rfclog

904a916

RDK-60308 [RFC] RDK Coverity Defect Resolution for Device

Merge pull request #174 from rdkcentral/develop

0d2d9c0

rebase

Create rdk_debug.h

9fae7ea

Update rfc_manager.cpp

b8758d4

Apply suggestion from @Copilot

8b0a25a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

ed665ce

Add RDK_LOG_FATAL definition to fallback log levels

8963bce

Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>

Final verification complete

efcabe1

Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>

Add .gitignore and remove build artifacts

c093093

Co-authored-by: nhanasi <107076221+nhanasi@users.noreply.github.com>

Merge pull request #177 from rdkcentral/copilot/sub-pr-175-again

faa6b7b

Add missing RDK_LOG_FATAL constant to fallback definitions

Apply suggestion from @Copilot

e3be91c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

nhanasi and others added 15 commits February 12, 2026 15:21

Apply suggestion from @Copilot

3dcde8e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update run_l2.sh

1e8d64d

Delete .gitignore

22c7e07

Update run_l2.sh

b63bb70

Update rfc_manager.cpp

ed35f15

RDKEMW-13945 Fix L2 Issue on RFC Component

f790109

Merge pull request #175 from rdkcentral/feature/rfclog

f329d0a

RDKB-63483: RFC Fix L1 Issues with new logger api

Merge branch 'develop' into feature/RDKEMW-13945

5e13181

Merge pull request #178 from rdkcentral/feature/RDKEMW-13945

359fc04

RDKEMW-13945 Fix L2 Issue on RFC Component

Update rfc_manager.cpp

7bf4644

Create rdk_debug.h

4359493

Merge branch 'develop' into feature/RDK-60308_final

b7196d8

Update rfc_manager.cpp

0087ec7

Merge pull request #162 from rdkcentral/feature/RDK-60308_final

60347d1

RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device

RFC 1.2.2 release changelog updates

22ff1bc

Copilot AI review requested due to automatic review settings February 16, 2026 20:37

nhanasi requested a review from a team as a code owner February 16, 2026 20:37

Copilot started reviewing on behalf of nhanasi February 16, 2026 20:37 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

nhanasi merged commit 49d0612 into main Feb 16, 2026
27 of 29 checks passed

github-actions Bot locked and limited conversation to collaborators Feb 16, 2026

nhanasi deleted the release/1.2.2 branch February 16, 2026 21:14

Navigation Menu

Uh oh!

RDK-60308 : RFC 1.2.2 release changelog updates - #180

RDK-60308 : RFC 1.2.2 release changelog updates#180
nhanasi merged 45 commits into
mainfrom
release/1.2.2

nhanasi commented Feb 16, 2026

Uh oh!

github-actions Bot commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

github-actions Bot commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);
	RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d] Failed to remove file %s, errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);

Uh oh!

Conversation

nhanasi commented Feb 16, 2026

Uh oh!

github-actions Bot commented Feb 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 16, 2026

Code Coverage Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants