fix: remove reliance on node_modules in paths to podspecs

[simka]

Summary:

Previous implementation assumed node_modules being somewhere in the
path to podspec file and relied on it to create relative path, which
broke monorepos (since config lists real filepaths instead of, as
I assumed previously, symlinks). New implementation subtracts project
root path from absolute path to podspec file for the purpose of generating
relative path.

Resolves #537

Test Plan:

Tested changes manually to verify correct paths in Podfile.lock, adjusted existing tests

[alloy]

Suggested change

	path = folder.partition(project_root).last()
	path = folder.split(project_root).last

I believe that partition is an activesupport extension, whereas split is core.

[simka]

right, even if partition is core I think split is more descriptive and straight-forward

[thymikee]

split().last returns nil when the left and right side is the same, while partition.last() converts this to empty string.

I pushed a fix for that in 500a868

[alloy]

I take it that “still have to adjust tests in native_modules.rb” is outdated, because this looks 👌

[alloy]

Nice one @maciejsimka!

[Salakar]

This change breaks local packages in mono-repos by the way;

Note the .. at the start of the path even though the path is already fully expanded (local symlinked package by lerna)

Changing the pod line to the following worked for me (whether that's the best solution I'm not sure):

    if relative_path.include?('node_modules')
      pod spec.name, :path => File.join(root, relative_path)
    else
      pod spec.name, :path => relative_path
    end

If this makes sense lmk and I'll send a PR. Thanks

[thymikee]

@maciejsimka do what do you think?

[simka]

it'd work, but wouldn't the second branch put an absolute path in Podfile.lock? I mean the relative_path is not a relative path at all in case of monorepo.

I came up with possible solution using pathname class, but I hadn't had the time to test it extensively, I'll try to prepare a WIP PR in the evening