fix: resolve CI build failure by mrmckeb · Pull Request #9640 · react/create-react-app

mrmckeb · 2020-09-14T09:46:43Z

No description provided.

iansu

Are you sure these changes aren't breaking?

iansu · 2020-09-14T17:57:26Z


 ```sh
-npm install --save-dev  eslint-plugin-jest@24.x
+npm install --save-dev eslint-plugin-jest@24.0.0


This should probably be @^24.0.0

Done, thanks!

iansu · 2020-09-14T17:58:10Z

+                  },
+                  plugins: ['react'],
+                  rules: {
+                    'react/jsx-uses-react': 'warn',


Why define these rules here?

Move to a base config as discussed.

tobiasbueschel

Nice that someone picks up the CI build failure @mrmckeb 👏 🙂

Just for my full understanding (as I'm still getting familiar with the CRA codebase), this PR intends to fix the build failure as seen on the master branch: https://github.com/facebook/create-react-app/runs/1112685524 is that correct?

$ cd packages/react-scripts && node bin/react-scripts.js build
Creating an optimized production build...
Failed to compile.

../cra-template/template/src/index.js
Syntax error: 'import' and 'export' may appear only with 'sourceType: module' (1:1)

The build now works, but I'm still curious how moving to a base config has fixed the aforementioned issue (maybe I'm missing some context here)?

tobiasbueschel · 2020-09-16T01:56:05Z

As we are already speaking about our CI pipelines, I've also noticed that some of our other pipelines are currently breaking - do we already have a plan to address this? Anything I can help with? ☺️

mrmckeb · 2020-09-16T07:07:13Z

I broke this one in particular @tobiasbueschel - but you're right, and we've been discussing this. We'll probably start rewriting soon, but need to get V4 out.

And no, this is because of another failure. I was looking at that failure too, but need to spend more time on it.

tobiasbueschel · 2020-09-16T07:14:02Z

I broke this one in particular @tobiasbueschel - but you're right, and we've been discussing this. We'll probably start rewriting soon, but need to get V4 out.

And no, this is because of another failure. I was looking at that failure too, but need to spend more time on it.

@mrmckeb keen for v4 as well - happy to help with the re-write once it's the right time, thanks :)

* Update packages (react#9081) * Fix dotenv file loading order (react#9037) * Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com> * feat: remove typescript flag and NODE_PATH support (react#8934) * Update question issue template * Update getting-started.md to match templates (react#9089) * Upgrade to Jest 26 (react#8955) * Update Jest to 26 * Upgrade to Jest 26.0.1 * Use jest-circus test runner by default * Try resolving test runner to fix behavior tests * Run TypeScript verification in new context * Delete globalThis if polyfilled * feat(react-scripts): allow testMatch for jest config (react#9114) resolves react#8637 * Add support for absolute paths when using url() in CSS (react#7937) * Support scss absolute path resolution for url() Adding resolve-url-loader broke all apps using scss with centralized assets folder and all url(./assets/*.png) broke (react#7023). This change allows apps to use url(/assets/*.png) and it would map to src/assets/*.png * test: Add global scss assets test * Upgrade dependencies (react#9132) * Fix typo in docs (react#9135) * Add performance relayer + documentation (web-vitals) (react#9116) Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update deployment docs for Azure Static Web Apps (react#9042) Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> * Replace Spectrum links with GitHub Discussions (react#9102) * Use process.execPath to spawn node subprocess (react#8694) * Upgrade dependencies (react#9196) * Bump version of Verdaccio (react#7787) * Support ESLint 7.x (react#8978) * Fix chai URL (react#8895) The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning. * Explain how to uninstall create-react-app globally (react#9244) * Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn * Upgrade dependencies (react#9317) * Switch to the Workbox InjectManifest plugin (react#9205) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Upgrade refresh plugin (react#9348) * feat: Update ESLint dependencies (react#9251) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Remove server worker registration from default templates (react#9349) * Clarify wording in adding TypeScript to existing project (react#9231) * feat: better refresh plugin integration (react#9375) * feat: exit on outdated create-react-app version (react#9359) * Prepare 4.0.0 alpha release * Updated README.md Templates to Follow ESLint Markdown Rules (react#9241) * [Doc] fix React Testing Library example (react#9245) * Update running-tests.md (react#9380) * Add Fast Refresh warning when using React < 16.10 (react#9350) * Publish refreshOverlayInterop with react-dev-utils (react#9390) * fix: remove deprecated rule (react#9401) * clean formatMessage usage (react#9059) * feat: Update testing-library dependencies to latest (react#9252) * fix: use default modules option from `preset-env` (react#9374) * Bump immer version (react#8933) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> * Upgrade whatwg-fetch (react#9392) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Fix template name handling (react#9412) * Prepare 4.0.0 alpha release * chore: update to jest@26.3 (react#9461) * Create SECURITY.md * Add 3.4.2 to changelog * Add 3.4.3 to the changelog * Fixes in the /packages/react-devs-utils/README.md file (react#9471) * Added CRA logo in README.md (react#9363) * Added React logo in README.md * Added React logo in README file that makes looks nicer now. * Added CRA Logo in README.md that looks nicer * Replacing React Logo with CRA Logo instead Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> * Update README.md Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> * Update Vercel deployment documentation (react#9560) * Fix insensitive language in Docusaurus docs (react#9618) * Remove ESLint extends and add Jest rules (react#9587) * fix: Fix azure-pipelines' endOfLine (react#9258) * Update template dependencies to latest version (react#9526) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update running-tests.md (react#9073) * feat: Update ESLint dependencies (react#9434) * Emphasise that Next.js is capable of SSG (react#9630) * docs: add alt tag to homepage logo (react#9499) * fix: resolve CI build failure (react#9640) * Use new JSX transform with React 17 (react#9645) * Upgrade dependencies (react#9639) * Prepare 4.0.0 alpha release * Update postcss-safe-parser * Prepare 4.0.0 alpha release * Update CODEOWNERS * fix: resolve ESLint config from appPath (react#9683) * Add AVIF image support (react#9611) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * fix: resolve new JSX runtime issues (react#9788) * Upgrade Docusaurus to latest version (react#9728) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Joe Haddad <timer150@gmail.com> Co-authored-by: Brody McKee <mrmckeb@hotmail.com> Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> Co-authored-by: Josemaria Nriagu <49484425+josenriagu@users.noreply.github.com> Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl> Co-authored-by: atlanteh <atlanteh@gmail.com> Co-authored-by: Jakob Krigovsky <jakob@krigovsky.com> Co-authored-by: Houssein Djirdeh <houssein.djirdeh@gmail.com> Co-authored-by: Burke Holland <burkeholland@gmail.com> Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Brian Morearty <brian@morearty.org> Co-authored-by: Nick McCurdy <nick@nickmccurdy.com> Co-authored-by: Jeffrey Posnick <jeffy@google.com> Co-authored-by: Dylan Brookes <24858006+merelinguist@users.noreply.github.com> Co-authored-by: Michael Mok <pmmmwh@gmail.com> Co-authored-by: Rafael Quijada <firehawk09@users.noreply.github.com> Co-authored-by: Sakito Mukai <sakito21@gmail.com> Co-authored-by: Andy C <7357845+andycanderson@users.noreply.github.com> Co-authored-by: Kline Moralee <klinemoralee@gmail.com> Co-authored-by: Gerrit Alex <admin@gerritalex.de> Co-authored-by: Sam Chen <chenxsan@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Stafford Williams <staff0rd@users.noreply.github.com> Co-authored-by: Lenard Pratt <striderman34@gmail.com> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Webdot_30 <nwaforuchechukwu2007@gmail.com> Co-authored-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com> Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Timothy <1695613+timothyis@users.noreply.github.com> Co-authored-by: Liam Duffy <3338808+liamness@users.noreply.github.com> Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com> Co-authored-by: Hongbo Miao <Hongbo.Miao@outlook.com> Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>

* Update template tests (react#8705) * Bump TypeScript template to 3.8 (react#8713) * Add .cjs and .mjs files support to test runner (react#8768) * Use simplified import of @testing-library/jest-dom (react#8763) * Include absoluteRuntime in babel preset docs (react#5847) * Specify what files are served form a bare local copy (react#8749) * fix: handle templates without main package field (react#8734) * Add experimental react-refresh support (react#8582) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Add setupTests.js to the list of generated files (react#8791) * Simplify wording in setting-up-your-editor.md (react#8684) * Update url to see prettier in action (react#8610) * Bump acorn from 6.4.0 to 6.4.1 in /docusaurus/website (react#8656) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Don't use webpack multi entry unnecessarily (react#8834) Passing an array with a single entry is not equivalent. This causes Webpack to generate another wrapper module around the entry. This is just unnecessary overhead and bytes. * Widen eslint-config-react-app peer dependency versions (react#8892) See react#7790 for a previous similar PR. * Revert "Replace favicon in templates (react#8194)" (react#8925) This reverts commit c03bb36. * Minor/patch dependency upgrades (react#8947) * Upgrade to Jest 25 (react#8362) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Drop Node 8 support (react#8948) * Bump React Hooks ESLint plugin to 4.0.0 (react#8939) * Update build script deployment URL (react#8651) * Do not check for interactive session to shut down dev server (react#8845) * Support source maps for scss in dev environments (react#8638) * Skip stdin resuming to support lerna parallel (react#8700) * Set resetMocks to true by default in jest config (react#7899) * Add import/no-anonymous-default-export lint rule (react#8926) * Upgrade testing-library packages (react#8406) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Bump style-loader to 1.2.1 (react#8891) * Support devDependencies in templates (react#8838) * fix react-refresh babel plugin not applied (react#8952) * Add a VSCode tip in the CSS reset section (react#8246) * Add back in --stats output from webpack. (react#8790) * Fix --use-pnp for Yarn 2 (react#8460) * Replace period in CSS Module classnames (react#8492) * Move shortlinks to cra.link (react#8957) * Remove outdated comment (react#8858) * bump webpack-dev-server to 3.11.0 (react#8975) Co-authored-by: Marc Hassan <marc@unqork.com> * Dependency major version upgrades (react#8950) * Update packages (react#9081) * Fix dotenv file loading order (react#9037) * Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com> * feat: remove typescript flag and NODE_PATH support (react#8934) * Update question issue template * Update getting-started.md to match templates (react#9089) * Upgrade to Jest 26 (react#8955) * Update Jest to 26 * Upgrade to Jest 26.0.1 * Use jest-circus test runner by default * Try resolving test runner to fix behavior tests * Run TypeScript verification in new context * Delete globalThis if polyfilled * feat(react-scripts): allow testMatch for jest config (react#9114) resolves react#8637 * Add support for absolute paths when using url() in CSS (react#7937) * Support scss absolute path resolution for url() Adding resolve-url-loader broke all apps using scss with centralized assets folder and all url(./assets/*.png) broke (react#7023). This change allows apps to use url(/assets/*.png) and it would map to src/assets/*.png * test: Add global scss assets test * Upgrade dependencies (react#9132) * Fix typo in docs (react#9135) * Add performance relayer + documentation (web-vitals) (react#9116) Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update deployment docs for Azure Static Web Apps (react#9042) Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> * Replace Spectrum links with GitHub Discussions (react#9102) * Use process.execPath to spawn node subprocess (react#8694) * Upgrade dependencies (react#9196) * Bump version of Verdaccio (react#7787) * Support ESLint 7.x (react#8978) * Fix chai URL (react#8895) The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning. * Explain how to uninstall create-react-app globally (react#9244) * Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn * Upgrade dependencies (react#9317) * Switch to the Workbox InjectManifest plugin (react#9205) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Upgrade refresh plugin (react#9348) * feat: Update ESLint dependencies (react#9251) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Remove server worker registration from default templates (react#9349) * Clarify wording in adding TypeScript to existing project (react#9231) * feat: better refresh plugin integration (react#9375) * feat: exit on outdated create-react-app version (react#9359) * Prepare 4.0.0 alpha release * Updated README.md Templates to Follow ESLint Markdown Rules (react#9241) * [Doc] fix React Testing Library example (react#9245) * Update running-tests.md (react#9380) * Add Fast Refresh warning when using React < 16.10 (react#9350) * Publish refreshOverlayInterop with react-dev-utils (react#9390) * fix: remove deprecated rule (react#9401) * clean formatMessage usage (react#9059) * feat: Update testing-library dependencies to latest (react#9252) * fix: use default modules option from `preset-env` (react#9374) * Bump immer version (react#8933) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> * Upgrade whatwg-fetch (react#9392) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Fix template name handling (react#9412) * Prepare 4.0.0 alpha release * chore: update to jest@26.3 (react#9461) * Create SECURITY.md * Add 3.4.2 to changelog * Add 3.4.3 to the changelog * Fixes in the /packages/react-devs-utils/README.md file (react#9471) * Added CRA logo in README.md (react#9363) * Added React logo in README.md * Added React logo in README file that makes looks nicer now. * Added CRA Logo in README.md that looks nicer * Replacing React Logo with CRA Logo instead Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> * Update README.md Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> * Update Vercel deployment documentation (react#9560) * Fix insensitive language in Docusaurus docs (react#9618) * Remove ESLint extends and add Jest rules (react#9587) * fix: Fix azure-pipelines' endOfLine (react#9258) * Update template dependencies to latest version (react#9526) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update running-tests.md (react#9073) * feat: Update ESLint dependencies (react#9434) * Emphasise that Next.js is capable of SSG (react#9630) * docs: add alt tag to homepage logo (react#9499) * fix: resolve CI build failure (react#9640) * Use new JSX transform with React 17 (react#9645) * Upgrade dependencies (react#9639) * Prepare 4.0.0 alpha release * Update postcss-safe-parser * Prepare 4.0.0 alpha release * Update CODEOWNERS * fix: resolve ESLint config from appPath (react#9683) * Add AVIF image support (react#9611) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * fix: resolve new JSX runtime issues (react#9788) * Upgrade Docusaurus to latest version (react#9728) * Replace deprecated eslint-loader with eslint-webpack-plugin (react#9751) * Replace deprecated eslint-loader by eslint-webpack-plugin * Update eslintFormatter for eslint-webpack-plugin * fix: always enable jsx-uses-react Co-authored-by: Brody McKee <mrmckeb@hotmail.com> * Add 3.4.4 to the changelog * Bump resolve-url-loader version (react#9841) * Bump resolve-url-loader version * Unpin resolve-url-loader * Fix refreshOverlayInterop module scope error (react#9805) * Make eslint-plugin-jest an optional peerDependency (react#9670) * feat(eslint-config-react-app): Add jest & testing-library rules (react#8963) * feat: Update ESLint dependencies (react#9856) * feat: remove unused React imports (react#9853) * feat: Update all dependencies (react#9857) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * New JSX Transform opt out (react#9861) * Use new JSX setting with TypeScript 4.1.0 (react#9734) * Upgrade to React 17 (react#9863) * Prepare 4.0.0 alpha release * Pass JSX runtime setting to Babel preset in Jest config (react#9865) * Prepare 4.0.0 release * Update CHANGELOG * Add link to Open Collective (react#9864) * Update CHANGELOG * Update react dom in error overlay * Prepare 4.0.0 release * Publish - babel-plugin-named-asset-import@0.3.7 - babel-preset-react-app@10.0.0 - confusing-browser-globals@1.0.10 - cra-template-typescript@1.1.0 - cra-template@1.1.0 - create-react-app@4.0.0 - eslint-config-react-app@6.0.0 - react-app-polyfill@2.0.0 - react-dev-utils@11.0.0 - react-error-overlay@6.0.8 - react-scripts@4.0.0 * undo antd-package removel Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Braedon Gough <38016720+braedongough@users.noreply.github.com> Co-authored-by: Andrey Sitnik <andrey@sitnik.ru> Co-authored-by: Kirill Korolyov <kirill.korolyov@gmail.com> Co-authored-by: Iddan Aaronsohn <mail@aniddan.com> Co-authored-by: Clément Hallet <clement@challet.eu> Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Adam Charron <adam@charrondev.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Mostafa Nawara <nawaragfx@gmail.com> Co-authored-by: Cory House <housecor@gmail.com> Co-authored-by: Michael Schmidt-Voigt <michael@schmidt-voigt.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Markbåge <sebastian@calyptus.eu> Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Kenneth Skovhus <skovhus@users.noreply.github.com> Co-authored-by: Sten Arthur Laane <laanesten@gmail.com> Co-authored-by: Jeremy Wadsack <jeremy.wadsack@gmail.com> Co-authored-by: Matt Korostoff <mkorostoff@gmail.com> Co-authored-by: Hieu Do <xlu.untitled@gmail.com> Co-authored-by: Alex Krolick <alexkrolick@users.noreply.github.com> Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com> Co-authored-by: Ernesto García <gnapse@gmail.com> Co-authored-by: Eugene Chybisov <imchybisov@gmail.com> Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com> Co-authored-by: Maaz Syed Adeeb <maaz.adeeb@gmail.com> Co-authored-by: Sam Saccone <samccone@gmail.com> Co-authored-by: Nick McCurdy <nick@nickmccurdy.com> Co-authored-by: Evan Kennedy <evan_kennedy@yahoo.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> Co-authored-by: Chetanya Kandhari <availchet@gmail.com> Co-authored-by: Marc Hassan <marc.j.hassan@gmail.com> Co-authored-by: Marc Hassan <marc@unqork.com> Co-authored-by: Joe Haddad <timer150@gmail.com> Co-authored-by: Brody McKee <mrmckeb@hotmail.com> Co-authored-by: Josemaria Nriagu <49484425+josenriagu@users.noreply.github.com> Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl> Co-authored-by: atlanteh <atlanteh@gmail.com> Co-authored-by: Jakob Krigovsky <jakob@krigovsky.com> Co-authored-by: Houssein Djirdeh <houssein.djirdeh@gmail.com> Co-authored-by: Burke Holland <burkeholland@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Brian Morearty <brian@morearty.org> Co-authored-by: Jeffrey Posnick <jeffy@google.com> Co-authored-by: Dylan Brookes <24858006+merelinguist@users.noreply.github.com> Co-authored-by: Michael Mok <pmmmwh@gmail.com> Co-authored-by: Rafael Quijada <firehawk09@users.noreply.github.com> Co-authored-by: Sakito Mukai <sakito21@gmail.com> Co-authored-by: Andy C <7357845+andycanderson@users.noreply.github.com> Co-authored-by: Kline Moralee <klinemoralee@gmail.com> Co-authored-by: Gerrit Alex <admin@gerritalex.de> Co-authored-by: Sam Chen <chenxsan@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Stafford Williams <staff0rd@users.noreply.github.com> Co-authored-by: Lenard Pratt <striderman34@gmail.com> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com> Co-authored-by: Webdot_30 <nwaforuchechukwu2007@gmail.com> Co-authored-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com> Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Timothy <1695613+timothyis@users.noreply.github.com> Co-authored-by: Liam Duffy <3338808+liamness@users.noreply.github.com> Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com> Co-authored-by: Hongbo Miao <Hongbo.Miao@outlook.com> Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com> Co-authored-by: Clément DUNGLER <clementdungler@gmail.com> Co-authored-by: Johannes Pfeiffer <johannespfeiffer@netnexus.de> Co-authored-by: Sai <sai@pelago.com.sg>

mrmckeb requested review from ianschmitz, iansu and petetnt as code owners September 14, 2020 09:46

facebook-github-bot added the CLA Signed label Sep 14, 2020

iansu suggested changes Sep 14, 2020

View reviewed changes

fix: resolve CI build failure

d9eb05f

mrmckeb force-pushed the feature/fix-build branch 2 times, most recently from 9275b75 to d9eb05f Compare September 15, 2020 07:39

iansu approved these changes Sep 15, 2020

View reviewed changes

ianschmitz added this to the 4.0 milestone Sep 15, 2020

ianschmitz approved these changes Sep 15, 2020

View reviewed changes

tobiasbueschel reviewed Sep 16, 2020

View reviewed changes

mrmckeb merged commit 552c7a9 into master Sep 16, 2020

mrmckeb deleted the feature/fix-build branch September 16, 2020 07:08

justinsilvestre pushed a commit to justinsilvestre/silveste-afa-create-react-app that referenced this pull request Oct 30, 2020

fix: resolve CI build failure (react#9640)

4babb3b

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021

fix: resolve CI build failure (react#9640)

ef5bf6a

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023

fix: resolve CI build failure (react#9640)

a27a105

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023

fix: resolve CI build failure (react#9640)

e10b875

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: resolve CI build failure#9640

fix: resolve CI build failure#9640
mrmckeb merged 1 commit into
masterfrom
feature/fix-build

mrmckeb commented Sep 14, 2020

Uh oh!

iansu left a comment

Uh oh!

iansu Sep 14, 2020

Uh oh!

mrmckeb Sep 15, 2020

Uh oh!

iansu Sep 14, 2020

Uh oh!

mrmckeb Sep 15, 2020

Uh oh!

tobiasbueschel left a comment

Uh oh!

tobiasbueschel commented Sep 16, 2020

Uh oh!

mrmckeb commented Sep 16, 2020 •

edited

Loading

Uh oh!

tobiasbueschel commented Sep 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

mrmckeb commented Sep 14, 2020

Uh oh!

iansu left a comment

Choose a reason for hiding this comment

Uh oh!

iansu Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

mrmckeb Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

iansu Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

mrmckeb Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

tobiasbueschel left a comment

Choose a reason for hiding this comment

Uh oh!

tobiasbueschel commented Sep 16, 2020

Uh oh!

mrmckeb commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasbueschel commented Sep 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mrmckeb commented Sep 16, 2020 •

edited

Loading