Document device name behavior for LCP registration#752
Merged
mickael-menu merged 1 commit intodevelopfrom Mar 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Documents the iOS 16+ change to UIDevice.current.name (generic device name) and how it impacts Readium LCP device registration, including recommended mitigations.
Changes:
- Add an LCP guide section describing iOS 16 device name behavior and mitigation options.
- Expand
LCPServiceinitializer docs to warn about iOS 16+ generic device names and the relevant entitlement.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/Guides/Readium LCP.md | Adds documentation for iOS 16 device-name behavior and options (entitlement or custom deviceName) for LCP registration. |
| Sources/LCP/LCPService.swift | Updates parameter documentation to clarify iOS 16+ behavior and entitlement requirement for user-assigned device names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
darktasevski
added a commit
to darktasevski/swift-toolkit
that referenced
this pull request
Apr 9, 2026
* upstream/develop: Fix decoration positions with paragraph indent (readium#767) Replace SwiftSoup with regex-based attribute lookup in Readium CSS injection (readium#742) Add support for SVG covers (readium#751) Fix race condition when applying EPUB decorations (readium#765) Add slide animation for adjacent EPUB resource transitions (readium#763) Remove unavailable APIs (readium#759) Remove Carthage support (readium#760) Improve `DirectionalNavigationAdapter` (readium#757) Update JSON usage from `Any` to `JSONValue` (readium#740) Fix LCP-enabled TestApp (readium#754) Report continuous `totalProgression` in the EPUB locator (readium#753) Document device name behavior for LCP registration (readium#752) Fix screen flashes during unanimated page turns in the EPUB navigator (readium#750) Fix parsing of URI templates (readium#749) Fix EPUB contributor role parsing (readium#748) Introduce the Readium Swift Playground (readium#746) # Conflicts: # Sources/Navigator/EPUB/Assets/Static/scripts/readium-fixed.js # Sources/Navigator/EPUB/Assets/Static/scripts/readium-reflowable.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since iOS 16,
UIDevice.current.namereturns a generic string (e.g. "iPhone") instead of the user-assigned device name. This affects LCP device registration with LSD servers, where the device name is used to identify the device.This PR adds a new section to the LCP guide explaining:
com.apple.developer.device-information.user-assigned-device-nameentitlement to restore the user-assigned namedeviceNameviaLCPService.initas an alternative