Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes Readium public APIs that were already marked as @available(*, unavailable) in 3.x, and cleans up the TestApp local integration setup by removing the checked-in Xcode workspace artifacts.
Changes:
- Removed multiple
unavailablePresentation-related APIs and types fromReadiumShared. - Removed the deprecated
Observable/MutableObservabletoolkit types. - Deleted
TestApp.xcworkspaceintegration files and updated the TestApp Makefile accordingly.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/NavigatorTests/UITests/NavigatorTestHost/ReaderViewController.swift | Updates the fatalError message in an unavailable storyboard initializer. |
| TestApp/Makefile | Stops copying/advertising the local TestApp.xcworkspace during generation. |
| TestApp/Integrations/Local/TestApp.xcworkspace/xcshareddata/IDETemplateMacros.plist | Removes obsolete workspace template macros file. |
| TestApp/Integrations/Local/TestApp.xcworkspace/contents.xcworkspacedata | Removes obsolete workspace definition file. |
| Sources/Shared/Toolkit/Observable.swift | Removes unused/unavailable observable types from the toolkit. |
| Sources/Shared/Publication/ReadingProgression.swift | Removes unavailable leadingPage API. |
| Sources/Shared/Publication/Extensions/Presentation/Properties+Presentation.swift | Removes unavailable Presentation-related Properties extensions. |
| Sources/Shared/Publication/Extensions/Presentation/Presentation.swift | Removes unavailable Presentation model and nested enums. |
| Sources/Shared/Publication/Extensions/Presentation/Metadata+Presentation.swift | Removes unavailable Metadata.presentation extension. |
| Sources/Shared/Publication/Extensions/EPUB/Properties+EPUB.swift | Removes unavailable EPUB presentation-hint properties, keeps contains. |
| Sources/Navigator/TTS/AVTTSEngine.swift | Updates the fatalError message in an unavailable storyboard initializer. |
| Sources/Navigator/PDF/PDFNavigatorViewController.swift | Removes unavailable scalesDocumentToFit API. |
Files not reviewed (1)
- TestApp/Integrations/Local/TestApp.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
darktasevski
added a commit
to darktasevski/swift-toolkit
that referenced
this pull request
Apr 9, 2026
* upstream/develop: Fix decoration positions with paragraph indent (readium#767) Replace SwiftSoup with regex-based attribute lookup in Readium CSS injection (readium#742) Add support for SVG covers (readium#751) Fix race condition when applying EPUB decorations (readium#765) Add slide animation for adjacent EPUB resource transitions (readium#763) Remove unavailable APIs (readium#759) Remove Carthage support (readium#760) Improve `DirectionalNavigationAdapter` (readium#757) Update JSON usage from `Any` to `JSONValue` (readium#740) Fix LCP-enabled TestApp (readium#754) Report continuous `totalProgression` in the EPUB locator (readium#753) Document device name behavior for LCP registration (readium#752) Fix screen flashes during unanimated page turns in the EPUB navigator (readium#750) Fix parsing of URI templates (readium#749) Fix EPUB contributor role parsing (readium#748) Introduce the Readium Swift Playground (readium#746) # Conflicts: # Sources/Navigator/EPUB/Assets/Static/scripts/readium-fixed.js # Sources/Navigator/EPUB/Assets/Static/scripts/readium-reflowable.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Readium APIs marked as
unavailablein 3.x.Also remove the
TestApp.xcworkspace. The file header does not work anymore and it's handled bymake format.