Fix decoration positions with paragraph indent#767
Merged
mickael-menu merged 2 commits intodevelopfrom Apr 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect EPUB decoration/highlight positioning when the paragraph indent user preference is enabled, by adjusting the ReadiumCSS user-override rules used by the Navigator.
Changes:
- Updated the paragraph-indent override CSS selector to stop resetting
text-indentonp:first-letter. - Applied the same CSS adjustment to both LTR and RTL ReadiumCSS “after” stylesheets.
- Updated
CHANGELOG.mdto mention the fix (and clarified wording about “decorations” vs “highlights”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/Navigator/EPUB/Assets/Static/readium-css/ReadiumCSS-after.css | Adjusted paragraph-indent override selector to avoid impacting :first-letter. |
| Sources/Navigator/EPUB/Assets/Static/readium-css/rtl/ReadiumCSS-after.css | Same selector adjustment for RTL stylesheet. |
| CHANGELOG.md | Documented the fix and refined related wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
grighakobian
pushed a commit
to grighakobian/swift-toolkit
that referenced
this pull request
Apr 9, 2026
darktasevski
added a commit
to darktasevski/swift-toolkit
that referenced
this pull request
Apr 9, 2026
* upstream/develop: Fix decoration positions with paragraph indent (readium#767) Replace SwiftSoup with regex-based attribute lookup in Readium CSS injection (readium#742) Add support for SVG covers (readium#751) Fix race condition when applying EPUB decorations (readium#765) Add slide animation for adjacent EPUB resource transitions (readium#763) Remove unavailable APIs (readium#759) Remove Carthage support (readium#760) Improve `DirectionalNavigationAdapter` (readium#757) Update JSON usage from `Any` to `JSONValue` (readium#740) Fix LCP-enabled TestApp (readium#754) Report continuous `totalProgression` in the EPUB locator (readium#753) Document device name behavior for LCP registration (readium#752) Fix screen flashes during unanimated page turns in the EPUB navigator (readium#750) Fix parsing of URI templates (readium#749) Fix EPUB contributor role parsing (readium#748) Introduce the Readium Swift Playground (readium#746) # Conflicts: # Sources/Navigator/EPUB/Assets/Static/scripts/readium-fixed.js # Sources/Navigator/EPUB/Assets/Static/scripts/readium-reflowable.js
grighakobian
pushed a commit
to grighakobian/swift-toolkit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Navigator