[composer-based] Report rule configuration bound to installed package version - #8247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8246. The
composer-basedcommand listed rules that declare aComposerPackageConstraint, but not the configuration registered throughruleWithConfigurationComposerVersionBound(). That configuration is exactly the interesting part - it is what decides whether e.g. oneAnnotationToAttributepair is applied or not, and there was no way to see it.RectorConfig::ruleWithConfigurationComposerVersionBound()now records every call as aComposerBoundRuleConfiguration, including the ones that do not match, and the command prints a second table:That last row is the point: on PHPUnit 13 the
RunClassInSeparateProcessattribute no longer exists, the pair is bound to>=10.0 <13.0, and the command shows it as inactive together with the exact pair it would have applied.Configuration values are printed compactly - value objects as
ShortClassName(prop, prop, ...), arrays as[a, b], string keys askey: value.Output above is a real run against rector-phpunit with
PHPUnitSetList::COMPOSER_BASED.Covered by two more cases in
ComposerBasedCommandTest- an active configuration and one whose package is not installed.