Fix aliases injected via use - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 76e88df. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches core Elixir LSP resolution paths (definition/hover/completion/rename/references) by expanding alias resolution using cached
__using__parsing; mistakes could cause widespread mis-resolutions or performance regressions on large projects.Overview
Fixes module resolution when a consumer relies on aliases injected by
usemacros.parseUsingBody/parseHelperQuoteBlocknow extractaliasdeclarations (includingas:and multi-alias forms) from__using__/helperquote doblocks and store them in theusingCacheEntry. The server merges these use-injected aliases (including transitiveusechains) into the in-scope alias map for definition/hover/completion/actions and ensures rename logic still treats only file-localas:aliases as renames.Adds unit tests covering alias extraction from
__using__and go-to-definition/hover resolution through a use-injected alias.Reviewed by Cursor Bugbot for commit 3c11912. Bugbot is set up for automated code reviews on this repo. Configure here.