Fix depth detection and respect formatting config - #4
Merged
JesseHerrick merged 2 commits intoApr 9, 2026
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd0162e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches core Elixir parsing used for alias scoping, reference extraction, and folding ranges, so subtle depth-detection regressions could affect navigation features. Disabling
WillSaveWaitUntilreduces behavior on save but is straightforward and covered by updated tests.Overview
Fixes Elixir scope/depth tracking by switching module-stack popping from indent-based heuristics to block depth counting that understands both
do..endand multi-linefn..end, while ignoring falsedo/endtokens in comments, strings, and heredocs via new helpers likeCheckHeredoc,StripCommentsAndStrings,IsEnd, andOpensBlock.Updates LSP features to use the same stripped-token logic for alias scoping (
ExtractAliasesInScope) and folding range detection, and disablesWillSaveWaitUntilformatting (capability flag off and handler returns nil), leaving formatting totextDocument/formatting. Adds regression tests forfnblocks, heredocs, and trailingfnpatterns, and updates the server test to expect no edits on will-save.Reviewed by Cursor Bugbot for commit a599cf7. Bugbot is set up for automated code reviews on this repo. Configure here.