Skip to content

Fix formatter _build dir lookup when inside an umbrella app - #5

Merged
JesseHerrick merged 1 commit into
open-source-releasefrom
fix-umbrella-app-formatter-build
Apr 9, 2026
Merged

Fix formatter _build dir lookup when inside an umbrella app#5
JesseHerrick merged 1 commit into
open-source-releasefrom
fix-umbrella-app-formatter-build

Conversation

@JesseHerrick

@JesseHerrick JesseHerrick commented Apr 8, 2026

Copy link
Copy Markdown
Member

Note

Medium Risk
Changes how the persistent formatter locates _build and deps and how arguments are passed into the Elixir formatter script, which can affect formatting/plugin loading across projects (especially umbrella layouts). Includes a new integration-style test covering symlinked _build behavior, reducing regression risk but still touching core formatting flow.

Overview
Fixes persistent formatter behavior inside umbrella Elixir apps by teaching formatter_server.exs to walk up from mix_root (bounded by projectRoot) to find the correct ancestor containing _build, and then using that project_root for plugin code paths and import_deps .formatter.exs resolution.

Updates the Go launcher (formatter.go) to pass projectRoot into the formatter script, and adds TestFormatterServer_UmbrellaStylerPlugin to verify Styler plugins load and apply when _build exists only at the umbrella root.

Reviewed by Cursor Bugbot for commit 8628481. Bugbot is set up for automated code reviews on this repo. Configure here.

@JesseHerrick
JesseHerrick merged commit 3109614 into open-source-release Apr 9, 2026
4 checks passed
remotecom pushed a commit that referenced this pull request Apr 9, 2026
Apparently GitHub just lets you merge a PR into a PR that has already
been merged rather than automatically updating the base. This adds back
the merged PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant