Fix formatter _build dir lookup when inside an umbrella app - #5
Merged
JesseHerrick merged 1 commit intoApr 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how the persistent formatter locates
_buildanddepsand how arguments are passed into the Elixir formatter script, which can affect formatting/plugin loading across projects (especially umbrella layouts). Includes a new integration-style test covering symlinked_buildbehavior, reducing regression risk but still touching core formatting flow.Overview
Fixes persistent formatter behavior inside umbrella Elixir apps by teaching
formatter_server.exsto walk up frommix_root(bounded byprojectRoot) to find the correct ancestor containing_build, and then using thatproject_rootfor plugin code paths andimport_deps.formatter.exsresolution.Updates the Go launcher (
formatter.go) to passprojectRootinto the formatter script, and addsTestFormatterServer_UmbrellaStylerPluginto verify Styler plugins load and apply when_buildexists only at the umbrella root.Reviewed by Cursor Bugbot for commit 8628481. Bugbot is set up for automated code reviews on this repo. Configure here.