refactor(symbols): CallPlan as closed Direct|Indirect variant - #76
Merged
Conversation
Host-aligned shell for call shape: variant arms instead of Kind+string. Codegen maps to CallKind for IR without reintroducing a parallel lattice.
2 tasks
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
coverage: 93.243% (+0.03%) from 93.217% — feature/callplan-variant into master |
2 tasks
Single IR bit mirrors isIndirectCall(CallPlan); no parallel enum lattice.
Owner
Author
Code reviewNo issues found. Checked for bugs, incomplete migrations, and stack consistency with Phase A goals. 🤖 Generated with Grok code-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CallPlan { Kind, calleeName }withstd::variant<DirectCallPlan, IndirectCallPlan>isIndirectCall/callCalleeName; genericget_iffor plansCalltakes a singlebool indirect(no parallelCallKindenum)Stack
Phase A PR 1/3 — foundation for later va_*/builtin call arms.
Test plan