refactor(symbols): AddressBaseMode for Field/Index plans - #77
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
2 tasks
rieske
force-pushed
the
feature/address-base-mode
branch
from
July 26, 2026 07:02
2293396 to
ce35301
Compare
|
coverage: 93.246% (+0.003%) from 93.243% — feature/address-base-mode into feature/callplan-variant |
Owner
Author
Code reviewNo issues found. Checked for bugs, incomplete migrations, and stack consistency with Phase A goals. 🤖 Generated with Grok code-review |
Replace dual baseIsPointer/baseIsArray flags with SA-owned AddressBaseMode (LeaObject | PointerValue | LvalueAddress). Propagate through Field/Index quadruples and StackMachine; LvalueAddress reserved for nested bases.
AddressBaseMode on IndexPlan is the sole base story. Remove unused AST flag and require IndexPlan for array codegen (Coveralls recovery).
AddressBaseMode is only LeaObject|PointerValue. addressBaseUsesLea names the LEA path without implying arrays only.
rieske
force-pushed
the
feature/address-base-mode
branch
from
July 26, 2026 08:47
ce35301 to
52bc4e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddressBaseMode(LeaObject|PointerValue) replacesbaseIsPointer/baseIsArrayon Field/Index plansLvalueAddress;addressBaseUsesLeanames the LEA pathStack
Phase A PR 2/3 — base: #76 CallPlan variant
Test plan