refactor(symbols): Result lives only on AnnotationStore - #78
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
rieske
force-pushed
the
feature/result-on-store
branch
2 times, most recently
from
July 26, 2026 06:30
d209754 to
f39ba54
Compare
rieske
force-pushed
the
feature/address-base-mode
branch
from
July 26, 2026 07:02
2293396 to
ce35301
Compare
rieske
force-pushed
the
feature/result-on-store
branch
from
July 26, 2026 07:09
f39ba54 to
06b873c
Compare
rieske
changed the title
|
coverage: 93.287% (+0.04%) from 93.246% — feature/result-on-store into master |
2 tasks
Owner
Author
Code reviewNo blocking issues found. Store-only Result migration is complete and consistent. Non-blocking notes (below confidence threshold for required fixes):
🤖 Generated with Grok code-review |
2 tasks
rieske
force-pushed
the
feature/address-base-mode
branch
from
July 26, 2026 08:47
ce35301 to
52bc4e1
Compare
rieske
force-pushed
the
feature/result-on-store
branch
from
July 26, 2026 08:47
a7a4507 to
d8bd5fe
Compare
Move ValueEntry into symbols/ and store ValueSlot::Result (and Lvalue) on AnnotationStore. Expression no longer dual-writes a node cache: has/get Result, valueType, and helper accessors all take the store. Drop unused PreOperation slot; SA/CG and tests use the store-only API.
Document Result-now / Lvalue-TBD on the store; getResultSymbol asserts via store.result() to match post-SA CG usage; extend clearEmptiesAll to cover Result and Lvalue slots.
rieske
force-pushed
the
feature/result-on-store
branch
from
July 26, 2026 08:52
d8bd5fe to
cdffa16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueEntrylives insymbols/(re-export fromsemantic_analyzer/ValueEntry.h)AnnotationStoreownsValueSlot::Result/Lvalue(no dual-write node cache)valueTypetakeAnnotationStore&PreOperationslotStack
Phase A PR 3/3 — base: #77 AddressBaseMode → #76 CallPlan
Test plan