fix(pegboard): fix prewarm logic #2409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved client selection logic and error handling for the Pegboard prewarming system and Actor API endpoints.
- Added ping threshold check in
pegboard.rsto filter out stale clients usingCLIENT_ELIGIBLE_THRESHOLD_MS - Switched to
StreamingMode::Iteratorinprewarm_imagefor comprehensive client scanning - Modified error handling in
actors.rsto capture last error instead of first error for better failure state visibility - Enhanced error message formatting in
createfunction to include both status and content details - Restructured client selection loop to return first eligible client rather than first available client
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+44
to
+47
| // Scan by last ping | ||
| if key.last_ping_ts < ping_threshold_ts { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
style: Consider adding a log when skipping clients due to ping threshold to help with debugging
Deploying rivet-hub with
|
| Latest commit: |
9f0d2d6
|
| Status: | 🚫 Build failed. |
Deploying rivet-studio with
|
| Latest commit: |
9f0d2d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f02ae1a.rivet-studio.pages.dev |
| Branch Preview URL: | https://04-28-fix-pegboard-fix-prewa.rivet-studio.pages.dev |
Deploying rivet with
|
| Latest commit: |
9f0d2d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04e36d8e.rivet.pages.dev |
| Branch Preview URL: | https://04-28-fix-pegboard-fix-prewa.rivet.pages.dev |
This was referenced Apr 29, 2025
Closed
Closed
MasterPtato
force-pushed
the
04-28-fix_pegboard_fix_prewarm_logic
branch
from
4b317df to
9f0d2d6
Compare
MasterPtato
force-pushed
the
04-23-fix_add_future_fdb_metrics
branch
from
2ffbbd6 to
8cd9d0a
Compare
This was referenced May 1, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes