Skip to content

fix: fix fdb cli, wf pulling #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: fix fdb cli, wf pulling #2418

wants to merge 1 commit into from

Conversation

@MasterPtato
Copy link
Contributor

Changes

@MasterPtato MasterPtato requested a review from NathanFlurry May 1, 2025 18:17
This was referenced May 1, 2025
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented May 1, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request May 1, 2025
Closed
greptile-apps[bot]
greptile-apps bot reviewed May 1, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances database operations and CLI functionality in the Rivet system. Here's a concise summary of the key changes:

  • Modified FDB CLI's set command to support dual-purpose key/value parameter, improving usability for command-line operations
  • Added proper error handling for SQLite initialization failures in workflow pulling process
  • Marked find_workflow as unimplemented in CockroachDB/NATS driver
  • Improved workflow data handling with Option<PulledWorkflowData> return type
  • Enhanced error recovery by adding workflow error message commits during SQLite failures

The changes focus on improving system resilience and user experience while maintaining proper error handling throughout the codebase.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 1, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 169d0bd
Status:🚫  Build failed.

View logs

@MasterPtato MasterPtato force-pushed the 05-01-fix_fix_fdb_cli_wf_pulling branch from 1650804 to 169d0bd Compare May 1, 2025 19:21
@MasterPtato MasterPtato force-pushed the 04-30-fix_add_udp_test_to_system_test branch from 42a5321 to 8b0fadf Compare May 1, 2025 20:12
@MasterPtato MasterPtato force-pushed the 05-01-fix_fix_fdb_cli_wf_pulling branch from 169d0bd to 9b476d9 Compare May 1, 2025 20:12
This was referenced May 1, 2025
Closed
Closed
Closed
@graphite-app
Copy link
Contributor

graphite-app bot commented May 2, 2025 •
edited
Loading

Merge activity

  • May 1, 9:57 PM EDT: MasterPtato added this pull request to the Graphite merge queue.
  • May 1, 9:58 PM EDT: CI is running for this pull request on a draft pull request (#2422) due to your merge queue CI optimization settings.
  • May 1, 9:59 PM EDT: Merged by the Graphite merge queue via draft PR: #2422.

graphite-app bot pushed a commit that referenced this pull request May 2, 2025
@MasterPtato
fix: fix fdb cli, wf pulling (#2418)
a8d5b7a 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this May 2, 2025
@graphite-app graphite-app bot deleted the 05-01-fix_fix_fdb_cli_wf_pulling branch May 2, 2025 01:59
@github-actions github-actions bot mentioned this pull request May 2, 2025
Merged
This was referenced May 2, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MasterPtato