fix: allow custom project for status monitor #2415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added optional project and environment fields to StatusQuery for customizable status monitoring, with fallback to system test configuration values.
- Added
project: Option<String>andenvironment: Option<String>toStatusQuerystruct inpackages/core/api/status/src/route/actor.rs - Modified status function to prioritize query parameters over system test config values
- Updated error handling to use
unwrap!macro for system test project validation - Added fallback to "prod" as default environment when neither query nor config specify one
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+53
to
59
| let system_test_project = unwrap!( | ||
| query | ||
| .project | ||
| .as_ref() | ||
| .or(status_config.system_test_project.as_ref()), | ||
| "system test project not configured" | ||
| ); |
There was a problem hiding this comment.
logic: unwrap! macro used here will panic if both query.project and status_config.system_test_project are None. Consider using unwrap_with! to provide a more specific error code
Suggested change
| let system_test_project = unwrap!( | |
| query | |
| .project | |
| .as_ref() | |
| .or(status_config.system_test_project.as_ref()), | |
| "system test project not configured" | |
| ); | |
| let system_test_project = unwrap_with!( | |
| query | |
| .project | |
| .as_ref() | |
| .or(status_config.system_test_project.as_ref()), | |
| INTERNAL_STATUS_CHECK_FAILED, | |
| error = "system test project not configured" | |
| ); |
Deploying rivet with
|
| Latest commit: |
cd8c696
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://597fb186.rivet.pages.dev |
| Branch Preview URL: | https://graphite-base-2377.rivet.pages.dev |
This was referenced May 1, 2025
Closed
Closed
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
04-30-fix_allow_custom_project_for_status_monitor
branch
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes