Skip to content

Conversation

@MasterPtato
Copy link
Contributor

Changes

Copy link
Contributor Author

MasterPtato commented May 1, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced error logging in the actors API by adding HTTP status codes and response content details to error messages, improving the ability to diagnose request failures across multiple endpoints.

  • Modified error handling in get_inner() to include HTTP status and response content in error logs
  • Updated destroy() function to provide more detailed error context for failed actor destruction requests
  • Enhanced error reporting in upgrade() and upgrade_all() to include complete response details
  • Improved error logging in list_actors_inner() to capture HTTP status codes and response content

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26e7680
Status:🚫  Build failed.

View logs

@graphite-app
Copy link
Contributor

graphite-app bot commented May 2, 2025

Merge activity

  • May 1, 9:57 PM EDT: MasterPtato added this pull request to the Graphite merge queue.
  • May 1, 9:58 PM EDT: CI is running for this pull request on a draft pull request (#2422) due to your merge queue CI optimization settings.
  • May 1, 9:59 PM EDT: Merged by the Graphite merge queue via draft PR: #2422.

graphite-app bot pushed a commit that referenced this pull request May 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@cloudflare-workers-and-pages
Copy link

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26e7680
Status:⚡️  Build in progress...

View logs

@graphite-app graphite-app bot closed this May 2, 2025
@graphite-app graphite-app bot deleted the 05-01-chore_fix_broadcast_req_error_logs branch May 2, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants