fix: add udp test to system test #2417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2025
Closed
Closed
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added UDP echo server functionality to the system test actor with client-side testing capabilities for network communication validation.
- Remove unnecessary
dgrampackage frompackage.jsonas it's a built-in Node.js module - Add timeout mechanism in
/examples/system-test-actor/tests/client.tsfor UDP response handling to prevent indefinite hangs - Convert UDP client operations in
/examples/system-test-actor/tests/client.tsto use proper async/await pattern - Consider adding cleanup handlers in
/examples/system-test-actor/src/container/main.tsfor UDP socket on server shutdown - Use existing actor object data instead of making additional API call for UDP port information
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| "@types/deno": "^2.2.0", | ||
| "@types/node": "^22.13.9", | ||
| "@types/ws": "^8.18.0", | ||
| "dgram": "^1.0.1", |
There was a problem hiding this comment.
logic: dgram is a built-in Node.js module and should not be added as an npm dependency. Remove this line as it's not needed.
Suggested change
| "dgram": "^1.0.1", |
| }); | ||
|
|
||
|
|
||
| const port2 = Number.parseInt(portEnv); |
There was a problem hiding this comment.
logic: No validation on port2 being a valid number - parseInt() could return NaN
Suggested change
| const port2 = Number.parseInt(portEnv); | |
| const port2 = Number.parseInt(portEnv); | |
| if (isNaN(port2)) { | |
| console.error('Invalid PORT_UDP value'); | |
| process.exit(1); | |
| } |
Comment on lines
+157
to
+160
| let res = await client.actor.get(actor.id, { | ||
| project: RIVET_PROJECT, | ||
| environment: RIVET_ENVIRONMENT, | ||
| }); |
There was a problem hiding this comment.
style: Unnecessary API call - the UDP port info is already available in the original actor object from line 34
Suggested change
| let res = await client.actor.get(actor.id, { | |
| project: RIVET_PROJECT, | |
| environment: RIVET_ENVIRONMENT, | |
| }); | |
| // Use UDP port info from the original actor object | |
| const udpPort = actor.network.ports.udp; |
Comment on lines
+167
to
+195
| // Create a UDP socket | ||
| const udpClient = dgram.createSocket('udp4'); | ||
|
|
||
| // Send a message to the UDP echo server | ||
| const message = Buffer.from('Hello UDP server!'); | ||
| udpClient.send(message, udpPort.port, udpPort.hostname, (err) => { | ||
| if (err) { | ||
| console.error("Error sending UDP message:", err); | ||
| udpClient.close(); | ||
| } else { | ||
| console.log("UDP message sent"); | ||
| } | ||
| }); | ||
|
|
||
| // Listen for a response | ||
| udpClient.on('message', (msg, rinfo) => { | ||
| console.log(`UDP message received: ${msg.toString()}`); | ||
| console.log(`From: ${rinfo.address}:${rinfo.port}`); | ||
| udpClient.close(); | ||
| }); | ||
|
|
||
| udpClient.on('error', (err) => { | ||
| console.error("UDP client error:", err); | ||
| udpClient.close(); | ||
| }); | ||
|
|
||
| udpClient.on('close', () => { | ||
| console.log("UDP connection closed"); | ||
| }); |
There was a problem hiding this comment.
logic: UDP operations are not properly awaited - wrap in Promise to ensure completion before test continues
Deploying rivet with
|
| Latest commit: |
42a5321
|
| Status: | 🚫 Build failed. |
MasterPtato
force-pushed
the
04-30-fix_add_udp_test_to_system_test
branch
from
42a5321 to
8b0fadf
Compare
MasterPtato
force-pushed
the
04-30-fix_fix_metrics
branch
from
9a55386 to
09dc9ec
Compare
This was referenced May 1, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 2, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes