Add job for clang build#239
Merged
christophfroehlich merged 7 commits intoros2-masterfrom Dec 7, 2024
Merged
Conversation
github-actions
bot
requested review from
bijoua29,
bmagyar,
homalozoa,
livanov93,
moriarty,
olivier-stasse and
saikishor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #239 +/- ##
============================================
Coverage 74.78% 74.78%
============================================
Files 22 22
Lines 1071 1071
Branches 85 85
============================================
Hits 801 801
Misses 222 222
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
changed the title
christophfroehlich
force-pushed
the
ci/clang
branch
2 times, most recently
from
c2431d0 to
3dd32fd
Compare
christophfroehlich
force-pushed
the
ci/clang
branch
from
3dd32fd to
8273971
Compare
christophfroehlich
force-pushed
the
ci/clang
branch
from
8273971 to
814ade3
Compare
christophfroehlich
changed the title
saikishor
requested changes
Dec 7, 2024
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
The changes look good to me. The clang job seem to fail due to the implicit conversions in the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ros-controls/realtime_tools#207
clang was complaining about implicit conversions in the PID class.