Skip to content

remove destroy timer from SoundType object - #286

Merged
knorth55 merged 1 commit into
ros-drivers:ros2from
tomkimsour:fix/remove-wrong-detroyer-call
Aug 5, 2026
Merged

remove destroy timer from SoundType object#286
knorth55 merged 1 commit into
ros-drivers:ros2from
tomkimsour:fix/remove-wrong-detroyer-call

Conversation

@tomkimsour

@tomkimsour tomkimsour commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

On destroy of SoundType object. The destroyer would call destroy_timer() but SoundType is not a Node and does not own a self.timer variable.

[soundplay_node.py-1] [ERROR] [1784810159.668171488] [soundplay_node]: Error setting up to play "beep.wav".Does this file exist on the machine on which sound_play is running?
[soundplay_node.py-1] Exception ignored in: <function SoundType.__del__ at 0x7fff9c5a2ca0>
[soundplay_node.py-1] Traceback (most recent call last):
[soundplay_node.py-1]   File "/home/thomasung/exchange/nix-humble/install/sound_play/lib/sound_play/soundplay_node.py", line 117, in __del__
[soundplay_node.py-1]     self.destroy_timer(self.timer)
[soundplay_node.py-1] AttributeError: 'SoundType' object has no attribute 'destroy_timer'

@knorth55
knorth55 merged commit 0c0a5fe into ros-drivers:ros2 Aug 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants