Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from include guards to pragma once #1615

Merged
merged 2 commits into from Aug 13, 2019
Merged

Switch from include guards to pragma once #1615

merged 2 commits into from Aug 13, 2019

Conversation

jonbinney
Copy link
Contributor

Description

Fixes #1597

Checklist

  • [x ] Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@jonbinney jonbinney mentioned this pull request Aug 13, 2019
Closed
@rhaschke rhaschke merged commit ae3d522 into ros-planning:master Aug 13, 2019
@rhaschke
Copy link
Collaborator

Thanks for this quick response to #1597.

davetcoleman
davetcoleman reviewed Aug 13, 2019
View reviewed changes
Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome +1!!

@davetcoleman
Copy link
Member

@jonbinney could you please update your style guide to specify this new rule?

This page:
https://github.com/ros-planning/moveit.ros.org/blob/gh-pages/documentation/contributing/code/index.markdown

@jonbinney
Copy link
Contributor Author

Sure. PR to update the style guide here: ros-planning/moveit.ros.org#324

@tylerjw tylerjw mentioned this pull request May 8, 2020
Closed
20 tasks
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
@jonbinney @tylerjw
Switch from include guards to pragma once (ros-planning#1615)
95a7211
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 12, 2020
@jonbinney @tylerjw
Switch from include guards to pragma once (ros-planning#1615)
0fc2258
tylerjw pushed a commit to PickNikRobotics/moveit that referenced this pull request May 20, 2020
@jonbinney @tylerjw
Switch from include guards to pragma once (ros-planning#1615)
eaf73c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetcoleman davetcoleman davetcoleman left review comments

@bmagyar bmagyar bmagyar approved these changes

@rhaschke rhaschke rhaschke approved these changes

@BryceStevenWilley BryceStevenWilley Awaiting requested review from BryceStevenWilley

@gavanderhoorn gavanderhoorn Awaiting requested review from gavanderhoorn gavanderhoorn is a code owner

@henningkayser henningkayser Awaiting requested review from henningkayser henningkayser is a code owner

@IanTheEngineer IanTheEngineer Awaiting requested review from IanTheEngineer

@jrgnicho jrgnicho Awaiting requested review from jrgnicho jrgnicho is a code owner

@mikeferguson mikeferguson Awaiting requested review from mikeferguson mikeferguson is a code owner

@mlautman mlautman Awaiting requested review from mlautman mlautman is a code owner

@v4hn v4hn Awaiting requested review from v4hn v4hn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using #pragma once, instead of include guards
4 participants
@jonbinney @rhaschke @davetcoleman @bmagyar