Re-add exec depend on python3 qt bindings rosdep key#160
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
mjcarroll
approved these changes
Apr 27, 2026
jmachowinski
approved these changes
Apr 27, 2026
cottsay
approved these changes
Apr 27, 2026
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
Should this also be a build_export_depend?
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Contributor
Author
|
Just linux CI, since I don't think testing this package.xml change on any other platforms would provide valuable results. Building up to qt_gui_cpp, testing python_qt_binding for package.xml linting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the source of the regression on rolling of qt_gui_cpp. When I replaced python3_qt5_bindings with
python3_qt_bindings, I mistakenly removed the exec_dependhttps://github.com/ros-visualization/python_qt_binding/pull/157/changes#diff-37a67ff78eb7260214b323353263b9af40a2fa98719a1e81937fae0159df87a3L34