Pick Qt version at build time, not install time#161
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
cottsay
approved these changes
Apr 28, 2026
Contributor
Author
|
CI (testing python_qt_binding and above)
|
mjcarroll
approved these changes
Apr 28, 2026
Contributor
Author
|
Green on all but windows. For the sake of time I'm going to merge assuming these changes are unlikely to behave any differently on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still trying to fix this rqt_image_view regression. I noticed this code seems problematic. It was using logic to find Qt6 to decide which version to use at both build time and run time. Once python_qt_binding is built, the version of Qt to use at run time must match what was built. This PR accomplishes that by turning the extras file into a template that
ament_packageexpands at build time.