Install pkg-config .pc file also on Windows/MSVC#169
Merged
scpeters merged 1 commit intoros:masterfrom Apr 25, 2023
Merged
Conversation
Contributor
Author
This was referenced Apr 2, 2022
Contributor
Author
|
Do you have any opinion on this @scpeters @clalancette @shane (i.e. the mantainers according to https://github.com/ros/urdfdom/blob/3.1.1/package.xml )? Thanks in advance! |
scpeters
approved these changes
Apr 25, 2023
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, both vcpkg and conda package managers explicitly support the use of pkg-config
.pcfiles. Consuming this files is done either via CMake'sFindPkgConfigmodule, or directly usingpkg-configtool with the--msvc-syntaxcommand line option (see https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/master/README.win32).For this reason, I do not think there is any reason for not installing
.pcfiles if the library is configured on Windows.