Add Client methods for checking and waiting for service availability #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
|
@jacobperron thanks, LGTM |
esteve
approved these changes
May 7, 2020
jacobperron
referenced
this pull request
in osrf/ros2_java
Nov 10, 2020
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
referenced
this pull request
in osrf/ros2_java
Nov 10, 2020
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
referenced
this pull request
in osrf/ros2_java
Nov 10, 2020
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
referenced
this pull request
in osrf/ros2_java
Nov 10, 2020
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 17, 2021
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
May 17, 2021
…85) * Re-enable tests related to services Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Add Client methods for checking and waiting for service availability These methods are very useful for allowing a client to wait for a service to be available before making requests. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Refactor ClientTest to avoid repeatedly sending requests Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #76 in order for tests to pass.
Re-enable the service-related tests with some modifications.