Skip to content

Add a pixi toml url to the build parameter arguments (ported from #839)#841

Draft
knmcguire wants to merge 15 commits intomasterfrom
knmcguire/windows-ci-parameters
Draft

Add a pixi toml url to the build parameter arguments (ported from #839)#841
knmcguire wants to merge 15 commits intomasterfrom
knmcguire/windows-ci-parameters

Conversation

@knmcguire
Copy link
Collaborator

See the description of #839

Ported to be a branch in ROS/ci so that we could more easily deploy it on a test ci job to test it out according to @claraberendsen

@knmcguire
Copy link
Collaborator Author

The idea is that we will try to deploy this particular branch on one of the test_ci jobs just to try it out since there is no CI to this PR. So we can wait with merging this PR after we have looked and settled that

@knmcguire knmcguire moved this from Todo to In Progress in Windows 11 Work! Feb 9, 2026
@cottsay cottsay force-pushed the knmcguire/windows-ci-parameters branch from 55973ff to 3d20cf7 Compare February 9, 2026 14:19
@cottsay
Copy link
Member

cottsay commented Feb 9, 2026

@knmcguire, I rebased this to make it easier to deploy to the test_* jobs, FYI.

@cottsay
Copy link
Member

cottsay commented Feb 9, 2026

Deployed here: https://ci.ros2.org/job/test_ci_windows/

@knmcguire
Copy link
Collaborator Author

Thanks! And good we tested it out here because it indeed fails! I will look into it 😄

@knmcguire knmcguire marked this pull request as draft February 9, 2026 16:39
@knmcguire
Copy link
Collaborator Author

Still testing things out in the test ci! the latest github outages delayed that a bit, so as soon as I confirm this working I'll convert it back to 'ready for review'

@knmcguire
Copy link
Collaborator Author

knmcguire commented Feb 13, 2026

Test with empty CI_PIXI_TOML_URL: Build Status

Test with msvc 2022 and with an alternative pixi.toml file (for the opencv fix) : Build Status

I don't think it is setting the pixi_toml_url correctly... so still some work to do here

@claraberendsen
Copy link
Contributor

@knmcguire I think what is missing is to correctly set the new variable as DOCKER_BUILD_ARGS

See the reference

if [ -n "${CI_ROS_DISTRO+x}" ]; then
export DOCKER_BUILD_ARGS="${DOCKER_BUILD_ARGS} --build-arg ROS_DISTRO=${CI_ROS_DISTRO}"
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants