Skip to content

Conversation

@Yadunund
Copy link
Member

Addresses #514

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with CI

@Yadunund
Copy link
Member Author

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde force-pushed the yadu/disable_linktime_composition_windows branch from 0233d59 to f391328 Compare October 2, 2025 14:32
@ahcorde
Copy link
Contributor

ahcorde commented Oct 2, 2025

Pulls: #640
Gist: https://gist.githubusercontent.com/ahcorde/ecf278523335c14350c438d1331b6982/raw/5a169a81b202b0c2abdd59fdd32d10fc632b80e4/ros2.repos
BUILD args: --packages-above-and-dependencies composition
TEST args: --packages-above composition
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17153

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 8c49a99 into rolling Oct 3, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the yadu/disable_linktime_composition_windows branch October 3, 2025 07:47
@ahcorde
Copy link
Contributor

ahcorde commented Oct 3, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Oct 3, 2025

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 8c49a99)
mergify bot pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 8c49a99)

# Conflicts:
#	composition/README.md
mergify bot pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 8c49a99)

# Conflicts:
#	composition/README.md
ahcorde added a commit that referenced this pull request Oct 6, 2025
(cherry picked from commit 8c49a99)

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 6, 2025
* Log message for linktime composition on Windows (#640)

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 8c49a99)
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 6, 2025
* Log message for linktime composition on Windows (#640)

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 8c49a99)
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: yadunund <yadunund@openrobotics.org>
Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants