Skip to content

Conversation

@khaledgabr77
Copy link
Contributor

While testing kilted_tutorial_party the Demo Nodes (C++) executables, I found a typo in the command under the Parameter Events Asynchronous section of the demo_nodes_cpp documentation.

The command currently:

ros2 run demo_nodes_cpp parameters_events_async

But the correct executable name is:

ros2 run demo_nodes_cpp parameter_events_async

Signed-off-by: khaledgabr77 <khaledgabr77@gmail.com>
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Since this only changes the README, I'll just rely on the Rpr job. I'll backport this to Kilted and Jazzy (there's no README in Humble).

@christophebedard christophebedard merged commit 3b2cedb into ros2:rolling May 3, 2025
3 checks passed
@christophebedard
Copy link
Member

@Mergifyio backport kilted jazzy

@mergify
Copy link
Contributor

mergify bot commented May 3, 2025

backport kilted jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request May 3, 2025
Signed-off-by: khaledgabr77 <khaledgabr77@gmail.com>
(cherry picked from commit 3b2cedb)
mergify bot pushed a commit that referenced this pull request May 3, 2025
Signed-off-by: khaledgabr77 <khaledgabr77@gmail.com>
(cherry picked from commit 3b2cedb)
christophebedard pushed a commit that referenced this pull request May 3, 2025
Signed-off-by: khaledgabr77 <khaledgabr77@gmail.com>
(cherry picked from commit 3b2cedb)

Co-authored-by: Khaled Gabr <30967695+khaledgabr77@users.noreply.github.com>
christophebedard pushed a commit that referenced this pull request May 3, 2025
Signed-off-by: khaledgabr77 <khaledgabr77@gmail.com>
(cherry picked from commit 3b2cedb)

Co-authored-by: Khaled Gabr <30967695+khaledgabr77@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants