Skip to content

fixup image_pipeline_demo #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2025
Merged

fixup image_pipeline_demo #755

merged 4 commits into from
Nov 24, 2025
+10 −7

Conversation

@wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 21, 2025 •
edited
Loading

Description

User's noticed (ros2/ros2_documentation#2333) that the behavior of the image_pipeline_demo related binaries in the intra_process_demo package were not behaving as depicted in the screenshots and not as described in the demo text.

This pull request was opened to fix the documentation and screenshots (ros2/ros2_documentation#5988), but I noticed and realized it was actually the demo code that was wrong and the demo documentation and screenshots were what should have been happening. I tracked it down to this commit that I made years ago that broke the expected behavior: 456b5ba

So this pull request fixed the behavior (using a unique_ptr instead of a shared_ptr in the image viewer), as well as modernizes it a bit, with better resolutions, text font size, and better window titles.

I will fixup the documentation too, with new screenshots and some slightly adjusted text to make sure everything is the way it was supposed to be. See ros2/ros2_documentation#6041

Fixes ros2/ros2_documentation#2333

Is this user-facing behavior change?

Yes, the demo should now work as intended.

Did you use Generative AI?

No.

Additional Information

As the original author of the demo, I believe this is the behavior I was intending to demonstrate here.

@wjwwood
increase resolution and text size (in these modern times)
0b7fce6 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
@wjwwood
improve window titles in image viewers
f0b1924 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
@wjwwood
revert back to unique_ptr in image view to fix demo purpose
7d100af 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
@wjwwood wjwwood self-assigned this Nov 21, 2025
@wjwwood wjwwood mentioned this pull request Nov 21, 2025
Merged
@wjwwood
Copy link
Member Author

wjwwood commented Nov 21, 2025

Opened ros2/ros2_documentation#6041 to update the docs and screenshots.

This was referenced Nov 21, 2025
Closed
Closed
@wjwwood
fixup lint error, line length
a425b0e 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
@wjwwood
Copy link
Member Author

wjwwood commented Nov 21, 2025 •
edited
Loading

CI:

  • Linux Build Status (updated after CI runner was interrupted)
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status (updated after CI runner was interrupted)
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@wjwwood thanks for taking time to fix this!

mini-1235
mini-1235 approved these changes Nov 22, 2025
View reviewed changes
Copy link
Contributor

@mini-1235 mini-1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ahcorde
Copy link
Contributor

ahcorde commented Nov 24, 2025

Pulls: #755
Gist: https://gist.githubusercontent.com/ahcorde/8176b86ad13e7dcd051b4a402f3e977f/raw/e17339de91b9cd2f41321b124916066ca6a24a5e/ros2.repos
BUILD args: --packages-above-and-dependencies intra_process_demo
TEST args: --packages-above intra_process_demo
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17584

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@wjwwood
Copy link
Member Author

wjwwood commented Nov 24, 2025

@ahcorde I went and found the restarted CI jobs, they all passed, see my updated comment.

@wjwwood
Copy link
Member Author

wjwwood commented Nov 24, 2025

I'll wait though, since your CI does slightly more, --packages-above intra_process_demo whereas I did just package select.

@ahcorde ahcorde merged commit 91c63e5 into rolling Nov 24, 2025
3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Nov 24, 2025

https://github.com/Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2025 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 24, 2025
@wjwwood @mergify
fixup image_pipeline_demo (#755)
72499fd 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
(cherry picked from commit 91c63e5)
@mergify mergify bot mentioned this pull request Nov 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Nov 24, 2025
@wjwwood @mergify
fixup image_pipeline_demo (#755)
a4c09f9 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
(cherry picked from commit 91c63e5)
@mergify mergify bot mentioned this pull request Nov 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Nov 24, 2025
@wjwwood @mergify
fixup image_pipeline_demo (#755)
eb393b6 
Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
(cherry picked from commit 91c63e5)
This was referenced Nov 24, 2025
Merged
Merged
Merged
Merged
@wjwwood wjwwood deleted the wjwwood/update_image_pipeline_demo branch November 24, 2025 18:47
ahcorde pushed a commit that referenced this pull request Nov 25, 2025
@mergify @wjwwood
fixup image_pipeline_demo (#755) (#758)
f3d52f3 
(cherry picked from commit 91c63e5)

Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
Co-authored-by: William Woodall <wjwwood@intrinsic.ai>
ahcorde pushed a commit that referenced this pull request Nov 25, 2025
@mergify @wjwwood
fixup image_pipeline_demo (#755) (#756)
a36cd27 
(cherry picked from commit 91c63e5)

Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
Co-authored-by: William Woodall <wjwwood@intrinsic.ai>
ahcorde pushed a commit that referenced this pull request Nov 25, 2025
@mergify @wjwwood
fixup image_pipeline_demo (#755) (#757)
d0f4a40 
(cherry picked from commit 91c63e5)

Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
Co-authored-by: William Woodall <wjwwood@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

+1 more reviewer

@mini-1235 mini-1235 mini-1235 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wjwwood wjwwood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation Error - Efficient Intra Process Communication

5 participants

@wjwwood @ahcorde @fujitatomoya @mini-1235