fixup image_pipeline_demo (backport #755) #757
Merged
+10
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User's noticed (ros2/ros2_documentation#2333) that the behavior of the
image_pipeline_demorelated binaries in theintra_process_demopackage were not behaving as depicted in the screenshots and not as described in the demo text.This pull request was opened to fix the documentation and screenshots (ros2/ros2_documentation#5988), but I noticed and realized it was actually the demo code that was wrong and the demo documentation and screenshots were what should have been happening. I tracked it down to this commit that I made years ago that broke the expected behavior: 456b5ba
So this pull request fixed the behavior (using a
unique_ptrinstead of ashared_ptrin the image viewer), as well as modernizes it a bit, with better resolutions, text font size, and better window titles.I will fixup the documentation too, with new screenshots and some slightly adjusted text to make sure everything is the way it was supposed to be. See ros2/ros2_documentation#6041
Fixes ros2/ros2_documentation#2333
Is this user-facing behavior change?
Yes, the demo should now work as intended.
Did you use Generative AI?
No.
Additional Information
As the original author of the demo, I believe this is the behavior I was intending to demonstrate here.
This is an automatic backport of pull request #755 done by [Mergify](https://mergify.com).