Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 24, 2025

Description

User's noticed (ros2/ros2_documentation#2333) that the behavior of the image_pipeline_demo related binaries in the intra_process_demo package were not behaving as depicted in the screenshots and not as described in the demo text.

This pull request was opened to fix the documentation and screenshots (ros2/ros2_documentation#5988), but I noticed and realized it was actually the demo code that was wrong and the demo documentation and screenshots were what should have been happening. I tracked it down to this commit that I made years ago that broke the expected behavior: 456b5ba

So this pull request fixed the behavior (using a unique_ptr instead of a shared_ptr in the image viewer), as well as modernizes it a bit, with better resolutions, text font size, and better window titles.

I will fixup the documentation too, with new screenshots and some slightly adjusted text to make sure everything is the way it was supposed to be. See ros2/ros2_documentation#6041

Fixes ros2/ros2_documentation#2333

Is this user-facing behavior change?

Yes, the demo should now work as intended.

Did you use Generative AI?

No.

Additional Information

As the original author of the demo, I believe this is the behavior I was intending to demonstrate here.


This is an automatic backport of pull request #755 done by [Mergify](https://mergify.com).

Signed-off-by: William Woodall <wjwwood@intrinsic.ai>
(cherry picked from commit 91c63e5)
@mergify mergify bot mentioned this pull request Nov 24, 2025
@ahcorde
Copy link
Contributor

ahcorde commented Nov 24, 2025

Pulls: #757
Gist: https://gist.githubusercontent.com/ahcorde/1f8d625f8327089cbe80b40a56f2905a/raw/8f16343f0b19b6fe96b3c1de73debada1a1d4665/ros2.repos
BUILD args: --packages-above-and-dependencies intra_process_demo
TEST args: --packages-above intra_process_demo
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17591

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit d0f4a40 into jazzy Nov 25, 2025
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-755 branch November 25, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants