Skip to content

improve test integrity with rmw_cyclonedds_cpp.#440

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/improve-test-for-cyclonedds
Mar 18, 2026
Merged

improve test integrity with rmw_cyclonedds_cpp.#440
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/improve-test-for-cyclonedds

Conversation

@fujitatomoya
Copy link
Collaborator

Description

address https://ci.ros2.org/job/ci_linux/28060/testReport/junit/launch_testing_examples.launch_testing_examples/check_msgs_launch_test/launch_testing_examples_check_msgs_launch_test/

  • before
=============================== warnings summary ===============================
test/test_flake8.py: 28 warnings
  Warning: This process (pid=91118) is multi-threaded, use of fork() may lead to deadlocks in the child.

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED launch_testing_examples/check_msgs_launch_test.py::launch_testing_examples.check_msgs_launch_test - launch_testing_examples.check_msgs_launch_test.TestFixture.test_check_if_ms...
============= 1 failed, 9 passed, 28 warnings in 72.00s (0:01:11) ==============
  • after
============================= 10 passed in 42.48s ==============================
Finished <<< launch_testing_examples [43.1s]

Part of ros2/rmw_cyclonedds#550

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Mar 18, 2026
@fujitatomoya
Copy link
Collaborator Author

Pulls: #440
Gist: https://gist.githubusercontent.com/fujitatomoya/14a71ab51bd524cc4b2e4426cb3b347d/raw/dbc54b2db11c97fd5f7c41a267afc9bc4e8936ba/ros2.repos
BUILD args: --packages-above-and-dependencies launch_testing_examples --cmake-args -DRMW_IMPLEMENTATION=rmw_cyclonedds_cpp
TEST args: --packages-above launch_testing_examples
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18535

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Pulls: #440
Gist: https://gist.githubusercontent.com/fujitatomoya/98c1ae4e47eddb1d51a522137df35668/raw/dbc54b2db11c97fd5f7c41a267afc9bc4e8936ba/ros2.repos
BUILD args: --packages-above-and-dependencies launch_testing_examples
TEST args: --packages-above launch_testing_examples
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18537

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 007f50e into rolling Mar 18, 2026
2 of 3 checks passed
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport humble jazzy kilted

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2026

backport humble jazzy kilted

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 18, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 007f50e)
mergify bot pushed a commit that referenced this pull request Mar 18, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 007f50e)
mergify bot pushed a commit that referenced this pull request Mar 18, 2026
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 007f50e)
ahcorde pushed a commit that referenced this pull request Mar 19, 2026
(cherry picked from commit 007f50e)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants