Adress cmake linter problems #37
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #31
This should address the cmake warnings in the performance jobs of the buildfarm.
To be backported to galactic after merging.
Reference:
https://build.ros2.org/view/Gci/job/Gci__nightly-performance_ubuntu_focal_amd64/99/#showFailuresLink
https://build.ros2.org/view/Gci/job/Gci__nightly-performance_ubuntu_focal_amd64/99/testReport/junit/performance_test/lint_cmake/linelength__src_idlgen_opendds_CMakeLists_txt_102_/
Tagging @cottsay as assigned and @clalancette for awareness.
Signed-off-by: Jorge Perez jjperez@ekumenlabs.com