Skip to content

Conversation

@Blast545
Copy link

@Blast545 Blast545 commented Mar 2, 2022

This should close #31

This should address the cmake warnings in the performance jobs of the buildfarm.
To be backported to galactic after merging.

Reference:
https://build.ros2.org/view/Gci/job/Gci__nightly-performance_ubuntu_focal_amd64/99/#showFailuresLink
https://build.ros2.org/view/Gci/job/Gci__nightly-performance_ubuntu_focal_amd64/99/testReport/junit/performance_test/lint_cmake/linelength__src_idlgen_opendds_CMakeLists_txt_102_/

Tagging @cottsay as assigned and @clalancette for awareness.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

@cottsay
Copy link
Member

cottsay commented Mar 17, 2022

Two things:

  1. Please submit these changes upstream to https://gitlab.com/ApexAI/performance_test/
  2. We're using the run_on_buildfarm branch on the buildfarm, not master

Once the PR is open upstream, we can consider merging this early in anticipation of them accepting the changes.

@cottsay cottsay self-assigned this Mar 17, 2022
@Blast545 Blast545 changed the base branch from master to run_on_buildfarm March 17, 2022 18:31
@Blast545 Blast545 changed the base branch from run_on_buildfarm to master March 17, 2022 18:32
@Blast545 Blast545 changed the base branch from master to run_on_buildfarm March 17, 2022 20:30
@Blast545 Blast545 closed this Mar 17, 2022
@Blast545 Blast545 force-pushed the blast545/fix_linter_issues branch from be1bda7 to cf9106e Compare March 17, 2022 20:37
@Blast545
Copy link
Author

  1. The upstream repository doesn't have the portion of the code affected by this patch.
    https://gitlab.com/ApexAI/performance_test/-/tree/master/performance_test/src
    I don't think there's a way to open a PR with this there, please correct me if I'm missing something.

  2. I rebased this locally and at some point I deleted the branch and now the UI think this was merged when it wasn't. I re opened this PR targetting run_on_buildfarm on Address cmake linter problems #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

👨‍🌾 Gci and Rci report cmake lint errors

2 participants