print warning message on owner node if the parameter operation fails.#3037
print warning message on owner node if the parameter operation fails.#3037fujitatomoya merged 1 commit intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Pull request overview
This PR promotes parameter service failure logs from debug to warning level so that parameter operation failures surface to users more clearly.
Changes:
- Change logging level from
RCLCPP_DEBUGtoRCLCPP_WARNfor failures inGetParametersandGetParameterTypesservices. - Change logging level from
RCLCPP_DEBUGtoRCLCPP_WARNfor failures inSetParametersandSetParametersAtomicallyservices. - Change logging level from
RCLCPP_DEBUGtoRCLCPP_WARNfor failures inDescribeParametersservice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde can you review this? i think this is most straight forward to have what we need to show for the user application.
|
Pulls: #3037 |
|
@Mergifyio backport kilted jazzy humble |
✅ Backports have been createdDetails
Cherry-pick of f8a7ace has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
… (backport #3037) (#3040) * print warning message on owner node if the parameter operation fails. (#3037) Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit f8a7ace) # Conflicts: # rclcpp/src/rclcpp/parameter_service.cpp * resolve conflict. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Description
Part of ros2/ros2#1794
Is this user-facing behavior change?
Yes, but only when parameter service operation fails.
Did you use Generative AI?
No
Additional Information