Skip to content

print warning message on owner node if the parameter operation fails.#3037

Merged
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/issues/1794
Jan 27, 2026
Merged

print warning message on owner node if the parameter operation fails.#3037
fujitatomoya merged 1 commit intorollingfrom
fujitatomoya/issues/1794

Conversation

@fujitatomoya
Copy link
Collaborator

Description

Part of ros2/ros2#1794

Is this user-facing behavior change?

Yes, but only when parameter service operation fails.

Did you use Generative AI?

No

Additional Information

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes parameter service failure logs from debug to warning level so that parameter operation failures surface to users more clearly.

Changes:

  • Change logging level from RCLCPP_DEBUG to RCLCPP_WARN for failures in GetParameters and GetParameterTypes services.
  • Change logging level from RCLCPP_DEBUG to RCLCPP_WARN for failures in SetParameters and SetParametersAtomically services.
  • Change logging level from RCLCPP_DEBUG to RCLCPP_WARN for failures in DescribeParameters service.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde can you review this? i think this is most straight forward to have what we need to show for the user application.

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Jan 26, 2026

Pulls: #3037
Gist: https://gist.githubusercontent.com/fujitatomoya/f3f409544300963d72241c48597ae2cd/raw/87e86d35c41d91270c5adfc218e4976a35be0714/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18043

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit f8a7ace into rolling Jan 27, 2026
8 of 9 checks passed
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport kilted jazzy humble

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

backport kilted jazzy humble

✅ Backports have been created

Details

Cherry-pick of f8a7ace has failed:

On branch mergify/bp/humble/pr-3037
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit f8a7ace.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/src/rclcpp/parameter_service.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Jan 27, 2026
…#3037)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f8a7ace)
mergify bot pushed a commit that referenced this pull request Jan 27, 2026
…#3037)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f8a7ace)
mergify bot pushed a commit that referenced this pull request Jan 27, 2026
…#3037)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f8a7ace)

# Conflicts:
#	rclcpp/src/rclcpp/parameter_service.cpp
jmachowinski pushed a commit that referenced this pull request Jan 30, 2026
…#3037) (#3038)

(cherry picked from commit f8a7ace)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
jmachowinski pushed a commit that referenced this pull request Jan 30, 2026
…#3037) (#3039)

(cherry picked from commit f8a7ace)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
jmachowinski pushed a commit that referenced this pull request Jan 30, 2026
… (backport #3037) (#3040)

* print warning message on owner node if the parameter operation fails. (#3037)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f8a7ace)

# Conflicts:
#	rclcpp/src/rclcpp/parameter_service.cpp

* resolve conflict.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants