Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 27, 2026

Description

Part of ros2/ros2#1794

Is this user-facing behavior change?

Yes, but only when parameter service operation fails.

Did you use Generative AI?

No

Additional Information


This is an automatic backport of pull request #3037 done by [Mergify](https://mergify.com).

…#3037)

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f8a7ace)

# Conflicts:
#	rclcpp/src/rclcpp/parameter_service.cpp
@mergify mergify bot added the conflicts label Jan 27, 2026
@mergify
Copy link
Contributor Author

mergify bot commented Jan 27, 2026

Cherry-pick of f8a7ace has failed:

On branch mergify/bp/humble/pr-3037
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit f8a7ace.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/src/rclcpp/parameter_service.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator

Pulls: #3040
Gist: https://gist.githubusercontent.com/fujitatomoya/412a0ef2c8138cce043a24dccb823e4d/raw/ca7943a9b740efb2b3d17cb8ea7e533f380fe000/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18051

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Jan 29, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski merged commit fea542a into humble Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants