Avoid unecessary creation of MultiThreadedExecutor (backport #3090)#3096
Merged
Avoid unecessary creation of MultiThreadedExecutor (backport #3090)#3096
Conversation
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com> (cherry picked from commit 8cd4d47)
fujitatomoya
approved these changes
Mar 12, 2026
Collaborator
|
Pulls: #3096
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoids the unecessary creation of a
MultiThreadedExecutorin thecomponent_container_mtnode.The overhead of creating an unecessary
MultiThreadedExecutorhere is quite minimal, but there is some amount of overhead due toExecutor's constructor.I just noticed this and thought I'd contribute this, even though quite minor.
Also, I added
consttonode, as afaik there's no reason not to here.Is this user-facing behavior change?
No.
Did you use Generative AI?
No. I don't use slop bots.
This is an automatic backport of pull request #3090 done by [Mergify](https://mergify.com).