Skip to content

Deprecate memory strategy#3136

Open
jmachowinski wants to merge 4 commits intoros2:rollingfrom
cellumation:deprecate_memory_strategy
Open

Deprecate memory strategy#3136
jmachowinski wants to merge 4 commits intoros2:rollingfrom
cellumation:deprecate_memory_strategy

Conversation

@jmachowinski
Copy link
Copy Markdown
Collaborator

@jmachowinski jmachowinski commented Apr 20, 2026

Description

Deprecate non used classes.

Is this user-facing behavior change?

Yes, we are deprecating classes.

Did you use Generative AI?

no

@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

Pulls: #3136
Gist: https://gist.githubusercontent.com/jmachowinski/382ea95dd8b92a54041198d8efd6ea83/raw/69818c60eea230890789986bd606aa7aa145d7ca/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19016

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski force-pushed the deprecate_memory_strategy branch from a942c3e to 1a556c1 Compare April 20, 2026 15:29
@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

Pulls: #3136
Gist: https://gist.githubusercontent.com/jmachowinski/250c26d288b21d72c1c057148a2a4c78/raw/69818c60eea230890789986bd606aa7aa145d7ca/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19017

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski mentioned this pull request Apr 20, 2026
Closed
mjcarroll
mjcarroll approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and opportunity for a comment.

Comment thread rclcpp/include/rclcpp/strategies/allocator_memory_strategy.hpp Outdated
Comment thread rclcpp/include/rclcpp/memory_strategy.hpp Outdated
Comment thread rclcpp/test/rclcpp/test_find_weak_nodes.cpp
#include "rclcpp/node.hpp"
#include "rclcpp/rclcpp.hpp"

RCPPUTILS_DEPRECATION_WARNING_OFF_START
Copy link
Copy Markdown
Member

@mjcarroll mjcarroll Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment about when these can be removed?

@jmachowinski jmachowinski mentioned this pull request Apr 20, 2026
Open
@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

Pulls: #3136, ros2/realtime_support#140
Gist: https://gist.githubusercontent.com/jmachowinski/035f4f9ecfde3bd4576b07ab5d702e16/raw/b51b36446441edc69029f4d5efe8bff2c8a5f99f/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski jmachowinski mentioned this pull request Apr 20, 2026
Open
@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

Pulls: #3136, ros2/realtime_support#140, ros2/demos#784
Gist: https://gist.githubusercontent.com/jmachowinski/b2428617b758d24476d9f89c24229067/raw/58041cd6fdf41d800ffd31be0ca8e38571ee3956/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

Pulls: #3136, ros2/realtime_support#140, ros2/demos#784
Gist: https://gist.githubusercontent.com/jmachowinski/0a247c77b74aacfd4b2bf9c5e4083bb1/raw/58041cd6fdf41d800ffd31be0ca8e38571ee3956/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

  • Linux Build Status
  • Linux-aarch64 Build Status

@jmachowinski
Copy link
Copy Markdown
Collaborator Author

jmachowinski commented Apr 20, 2026

Pulls: #3136, ros2/realtime_support#140, ros2/demos#784
Gist: https://gist.githubusercontent.com/jmachowinski/93573f41f2b6bed9d11847c7d2217eaa/raw/58041cd6fdf41d800ffd31be0ca8e38571ee3956/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19026

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented Apr 21, 2026

  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Janosch Machowinski and others added 4 commits April 21, 2026 15:45
feat: Deprecate AllocatorMemoryStrategy
a7c1a2f 
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
feat: Deprecate MemoryStrategy as well
50f3b1e 
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
@jmachowinski @mjcarroll
Apply suggestions from code review
a12d5fd 
Co-authored-by: Michael Carroll <mjcarroll.oss@gmail.com>
Signed-off-by: Janosch Machowinski <jmachowinski@users.noreply.github.com>
chore: Added comments on when to remove
b7d7355 
Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
@jmachowinski jmachowinski force-pushed the deprecate_memory_strategy branch from ee4b161 to b7d7355 Compare April 21, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@skyegalaxy skyegalaxy skyegalaxy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmachowinski @fujitatomoya @mjcarroll @skyegalaxy