Deprecate the experimental EventsExecutor#3192
Open
skyegalaxy wants to merge 3 commits into
Open
Conversation
added 3 commits
July 13, 2026 15:12
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
ahcorde
approved these changes
Jul 14, 2026
Contributor
|
Pulls: #3192
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a compile-time deprecation warning when using the experimental EventsExecutor, warning to switch to the new Callback Group Events Executor in single-threaded mode instead.
Tests which exercise the EventsExecutor have deprecation warnings disabled while it is still in the source tree.
Also replaces one usage of the old executor with the new one in
rclcpp_action/test_server.cpp.Fixes # (issue)
Is this user-facing behavior change?
Users will now get a compiler warning when using the experimental EventsExecutor in their application code
Did you use Generative AI?
Claude Opus 4.8 was used to identify spots in the codebase where the deprecation warning suppression should be introduced.
Additional Information
This ought to be backported to at least Lyrical