Change syntax __VAR_ARGS__ to __VA_ARGS__#376
Merged
fujitatomoya merged 2 commits intoros2:rollingfrom Aug 26, 2022
yakuni:rolling
Merged
Change syntax __VAR_ARGS__ to __VA_ARGS__#376fujitatomoya merged 2 commits intoros2:rollingfrom yakuni:rolling
fujitatomoya merged 2 commits intoros2:rollingfrom
yakuni:rolling
Conversation
Signed-off-by: Yakumoo <crater.broker0f@icloud.com> Signed-off-by: Yakumo KUNIMOTO <yakumo@yakumos-imac.home>
Collaborator
|
I believe this is a bug, and should be fixed. see https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html |
fujitatomoya
approved these changes
Aug 25, 2022
Collaborator
|
Based on the description that #if defined(__has_feature)
#define my__has_feature __has_feature
#else
#define my__has_feature(x) 0
#endif |
Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com>
iuhilnehc-ynos
approved these changes
Aug 26, 2022
Collaborator
|
CI:
|
Collaborator
|
@Mergifyio backport this humble galactic foxy |
mergify Bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> (cherry picked from commit c49b41c)
mergify Bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> (cherry picked from commit c49b41c)
mergify Bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> (cherry picked from commit c49b41c)
✅ Backports have been createdDetails
|
fujitatomoya
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com> (cherry picked from commit c49b41c)
fujitatomoya
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com> (cherry picked from commit c49b41c)
fujitatomoya
pushed a commit
that referenced
this pull request
Aug 26, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> (cherry picked from commit c49b41c)
clalancette
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> (cherry picked from commit c49b41c) Co-authored-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com> (cherry picked from commit c49b41c) Co-authored-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com>
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Change syntax __VAR_ARGS__ to __VA_ARGS__ Signed-off-by: Yakumoo <crater.broker0f@icloud.com> * Remove __VA_ARGS__ Signed-off-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com> (cherry picked from commit c49b41c) Co-authored-by: Yakumoo <26108275+Yakumoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to these 2 links (quora, epics), VA_ARGS should be preferred over VAR_ARGS.