Skip to content

Fix wording in testing section Developer-Guide.rst #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clalancette merged 1 commit into from
Feb 8, 2023
Merged

Fix wording in testing section Developer-Guide.rst #3312

clalancette merged 1 commit into from
Feb 8, 2023

Conversation

@jsduenass
Copy link
Contributor

@jsduenass jsduenass commented Feb 7, 2023

Close #3310

clalancette
clalancette approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 8, 2023
@clalancette clalancette merged commit 7a0060c into ros2:rolling Feb 8, 2023
@mergify mergify bot mentioned this pull request Feb 8, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 8, 2023
@jsduenass @mergify
Fix wording in testing section Developer-Guide.rst (#3312)
b3a717a 
Close #3310

(cherry picked from commit 7a0060c)
@mergify mergify bot mentioned this pull request Feb 8, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 8, 2023
@jsduenass @mergify
Fix wording in testing section Developer-Guide.rst (#3312)
80d5843 
Close #3310

(cherry picked from commit 7a0060c)
clalancette pushed a commit that referenced this pull request Feb 8, 2023
@mergify @jsduenass
Fix wording in testing section Developer-Guide.rst (#3312) (#3316)
ed23a3b 
Close #3310

(cherry picked from commit 7a0060c)

Co-authored-by: Juan Sebastian Dueñas <jsduenass@unal.edu.co>
clalancette pushed a commit that referenced this pull request Feb 8, 2023
@mergify @jsduenass
Fix wording in testing section Developer-Guide.rst (#3312) (#3315)
d75304c 
Close #3310

(cherry picked from commit 7a0060c)

Co-authored-by: Juan Sebastian Dueñas <jsduenass@unal.edu.co>
@jsduenass jsduenass deleted the patch-2 branch April 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow

Assignees

No one assigned

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unclear wording under the section 'testing' in the Developer-Guide

3 participants

@jsduenass @clalancette @fujitatomoya