Skip to content

[stable] Prepare Rust 1.91.0 release #148179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: stable
Choose a base branch
from
Open

[stable] Prepare Rust 1.91.0 release #148179

wants to merge 9 commits into from
+1,060 −219

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Oct 27, 2025 •
edited
Loading

r? cuviper

theemathas and others added 7 commits October 27, 2025 21:49
@theemathas
[beta-1.91] Add more context to the temporary lifetime extension FCW
6ab240d 
Mention in the FCW that the lifetime extension behavior was wrong since 1.88/1.89.
@notriddle @cuviper
rustdoc-search: reduce async machinery in value lookups
063ccaa 
This commit is a mirrored change from stringdex that
makes `at()` not always return a promise, which is fine because
we can still `await` it.

(cherry picked from commit 43d45ef)
@notriddle @cuviper
rustdoc-search: delay loading type name IDs until type search
b77c3b1 
This avoids blocking on these lookups, so name-based searches
return results more quickly.

(cherry picked from commit 277e845)
@notriddle @cuviper
rustdoc-search: use the same ID for entry and path to same item
8127760 
This decreases the size of the compiler-doc from 57MiB to 56MiB.

(cherry picked from commit b9037f9)
@notriddle @cuviper
rustdoc-search: add descriptive comment to space-saving hack
b0dd64f 
(cherry picked from commit 9dce3e8)
@notriddle @cuviper
rustdoc-search: stringdex update with more packing
716b84e 
Before:

    18M  build/x86_64-unknown-linux-gnu/doc/search.index/
    57M  build/x86_64-unknown-linux-gnu/compiler-doc/search.index/

After:

    16M  build/x86_64-unknown-linux-gnu/doc/search.index/
    49M  build/x86_64-unknown-linux-gnu/compiler-doc/search.index/

(cherry picked from commit 5bec161)
@notriddle @cuviper
rustdoc-search: stringdex 0.0.2
7ce3022 
Two index format tweaks that reduce the size of the standard
library, compiler, and wordnet dictionary when I test it.

(cherry picked from commit fdeb363)
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-rustdoc-search Area: Rustdoc's search feature A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 27, 2025
@cuviper cuviper mentioned this pull request Oct 27, 2025
Open
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Oct 27, 2025
@rustbot

This comment has been minimized.

Sign in to view
@cuviper
Copy link
Member Author

cuviper commented Oct 27, 2025

@bors r+ rollup=never p=1000

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit 366b175 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
y21 and others added 2 commits October 27, 2025 10:58
@y21 @cuviper
fix(len_zero): don't eagerly call GenericArgs::type_at (rust-lang#1…
e4f5031 
…5660)

Fixes rust-lang/rust-clippy#15657

changelog: [`len_zero`]: fix ICE when `fn len` has a return type without
generic type params
@cuviper
1.91.0 stable release
be999ad
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@cuviper
Copy link
Member Author

cuviper commented Oct 27, 2025

Commit e10fc25, Further revert Deref for Cow to its 1.90.0 state, was meant as an even more conservative revert, but given that it broke the related test, I'm dropping that.

@cuviper cuviper mentioned this pull request Oct 27, 2025
Open
@cuviper
Copy link
Member Author

cuviper commented Oct 27, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit be999ad has been approved by cuviper

It is now in the queue for this repository.

@fmease fmease mentioned this pull request Oct 27, 2025
Closed
@bors
Copy link
Collaborator

bors commented Oct 27, 2025

⌛ Testing commit be999ad with merge 40c4f6d...

bors added a commit that referenced this pull request Oct 27, 2025
@bors
Auto merge of #148179 - cuviper:stable-next, r=cuviper
40c4f6d 
[stable] Prepare Rust 1.91.0 release

- [beta-1.91] Add more context to the temporary lifetime extension FCW #148174
- rustdoc-search: JavaScript optimization based on Firefox Profiler output #146484
- rustdoc-search: use the same ID for entry and path to same item #147045
- rustdoc-search: stringdex update with more packing #147002
- rustdoc-search: stringdex 0.0.2 #147660
- [beta] Clippy beta backport #148029
- 1.91.0 release notes #148013

r? cuviper
@cuviper cuviper mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-CI Area: Our Github Actions CI A-rustdoc-search Area: Rustdoc's search feature A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cuviper @rustbot @bors @rust-log-analyzer @theemathas @notriddle @y21