Rollup of 9 pull requests #149603

matthiaskrgr · 2025-12-03T18:24:39Z

Successful merges:

Fix ICE when applying test macro to crate root #147841 (Fix ICE when applying test macro to crate root)
CTFE: avoid emitting a hard error on generic normalization failures #149501 (CTFE: avoid emitting a hard error on generic normalization failures)
Implement blessing for tidy alphabetical check #149517 (Implement blessing for tidy alphabetical check)
Improve io::Error::downcast #149521 (Improve io::Error::downcast)
fix the check for which expressions read never type #149545 (fix the check for which expressions read never type)
Regression test for system register ttbr0_el2 #149549 (Regression test for system register ttbr0_el2)
Motor OS: fix compile error #149579 (Motor OS: fix compile error)
Tidying up tests/ui/issues tests [2/N] #149595 (Tidying up tests/ui/issues tests [2/N])
Revert "implement and test Iterator::{exactly_one, collect_array}" #149597 (Revert "implement and test Iterator::{exactly_one, collect_array}")

r? @ghost
@rustbot modify labels: rollup

This slightly changes alphabetical lint semantics... specifically if an "item" is multiline (when the next line does not have the same indentation) we now consider all lines (ignoring starting whitespace) for ordering, not just the first one.

…ed_to_constitute_read_for_never` to more accessible locations

...wrt `type_ascribe`/unsafe binders -- the check was infinitely recursive before.

... since unreachable-code only has a few tests while `reachable` is the more popular directory...

[PR 148765](rust-lang#148765) changed the expected signature of Thread::new(), which broke Motor OS target. Also set thread name.

tests/ui/issues/issue-4935 is duplicated of tests/ui/argument-suggestions/suggest-better-removing-issue-126246.rs

`tests/ui/type-inference/ambiguous-num-type-method-call.rs`

`tests/ui/mismatched_types/assignment-mismatch-various-types.rs` merge `tests/ui/mismatched_types/main.rs`

This reverts commit 699184b.

This reverts commit f201752.

…flelapkin Fix ICE when applying test macro to crate root This PR does a couple of things. First of all, I found [an ICE](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=a733a7f3d223e1a9712e44b571f3e5cf) that happens when applying `#![core::prelude::v1::test]` to the crate root. This is caused by the test macro not expanding to an item when `--test` isn't applied. For the crate root, that means it deletes the crate.... The fix now first does target checking, and only if the target is valid discards the item when `--test` isn't applied. The discarding is, I think, important for perf. The problem with this PR is that it means that `#[test]` applied to structs previously would give no errors unless `--test` is applied! That sounds like a bug to me, but maybe we should crater run it just in case, since technically that's a breaking change. Errors in such items wouldn't be reported previously. Also fixed a smol diagnostics bug with `#[bench]`'s error messages refering to `#[test]` accidentally. r? noratrieb (since I already explained you a bunch, feel free to re-assign) Fixes rust-lang#114920

matthiaskrgr · 2025-12-03T18:25:09Z

@bors r+ rollup=never p=5

bors · 2025-12-03T18:25:12Z

📌 Commit cd923ac has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-12-03T18:31:30Z

⌛ Testing commit cd923ac with merge 3b19ef9...

Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-12-03T19:17:28Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Command `git clone --depth=1 https://github.com/rust-lang-nursery/rust-toolstate rust-toolstate` failed with exit code 128
Created at: src/bootstrap/src/core/build_steps/toolstate.rs:314:5
Executed at: src/bootstrap/src/core/build_steps/toolstate.rs:319:10

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test --stage 2 check-tools`
Build completed unsuccessfully in 0:00:08
  local time: Wed Dec  3 19:17:16 UTC 2025
  network time: Wed, 03 Dec 2025 19:17:16 GMT
##[error]Process completed with exit code 1.

matthiaskrgr · 2025-12-03T19:18:30Z

@bors retry

Cloning into 'rust-toolstate'...

remote: Internal Server Error
fatal: unable to access 'https://github.com/rust-lang-nursery/rust-toolstate/': The requested URL returned error: 500<

matthiaskrgr · 2025-12-03T19:20:03Z

@bors retry

matthiaskrgr · 2025-12-03T19:24:58Z

@bors retry r-

matthiaskrgr · 2025-12-03T19:25:06Z

@bors r+

bors · 2025-12-03T19:25:09Z

📌 Commit cd923ac has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-12-04T03:22:25Z

⌛ Testing commit cd923ac with merge 0325719...

Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-12-04T05:01:23Z

The job aarch64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- alphabetical::tests::bless_smoke stdout ----

thread 'alphabetical::tests::bless_smoke' (6236) panicked at src\tools\tidy\src\alphabetical.rs:245:48:
called `Result::unwrap()` on an `Err` value: PersistError(Os { code: 5, kind: PermissionDenied, message: "Access is denied." })
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
---- alphabetical::tests::bless_smoke stdout end ----
---- alphabetical::tests::bless_funny_numbers stdout ----

---

error: test failed, to rerun pass `--lib`
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 1:28:15
make: *** [Makefile:112: ci-msvc-py] Error 1
  local time: Thu Dec  4 05:01:00 CUT 2025
  network time: Thu, 04 Dec 2025 05:01:00 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

bors · 2025-12-04T05:01:55Z

💔 Test failed - checks-actions

lcnr and others added 30 commits December 1, 2025 13:00

add test

9549166

generic normalization errors to TooGeneric

02d84c8

io::Error::downcast: avoid reallocation in case of failure

7de190a

add a tidy test

46f4b5d

refactor tidy alphabetical lint

3a0f23b

This slightly changes alphabetical lint semantics... specifically if an "item" is multiline (when the next line does not have the same indentation) we now consider all lines (ignoring starting whitespace) for ordering, not just the first one.

implement tidy bless for alphabetical blocks

4fef9bd

bless tidy tests

a93d661

drive-by: tidy: fixup style

3e811b3

bless tidy

dcc785d

Regression tests for system register ttbr0_el2

7922479

move expr_guaranteed_to_constitute_read_for_never and `pat_guarante…

62f7cf4

…ed_to_constitute_read_for_never` to more accessible locations

add a test for nested type ascriptions of never type

784b283

fix the check for which expressions read never type

c5f15bd

...wrt `type_ascribe`/unsafe binders -- the check was infinitely recursive before.

Move tests/ui/{unreachable-code => reachable}

ef27140

... since unreachable-code only has a few tests while `reachable` is the more popular directory...

Motor OS: fix compile error

537a8d7

[PR 148765](rust-lang#148765) changed the expected signature of Thread::new(), which broke Motor OS target. Also set thread name.

add one more test for type ascription of never

bf0970f

moved and deleted test

5e802dd

tests/ui/issues/issue-4935 is duplicated of tests/ui/argument-suggestions/suggest-better-removing-issue-126246.rs

Added comment to

07b1dad

`tests/ui/type-inference/ambiguous-num-type-method-call.rs`

Added comment to

245096b

`tests/ui/mismatched_types/assignment-mismatch-various-types.rs` merge `tests/ui/mismatched_types/main.rs`

Added comment to tests\ui\str\debug-print-basic-tuple.rs

cc230fb

Merged tests\ui\type-inference\type-inference-unconstrained-none.rs

d1bc6e3

add tests for tidy alphabetical blessing

8b6431d

fix guard patterns interaction with never type

e4f02e4

Revert "implement and test Iterator::{exactly_one, collect_array}"

eb03ea4

This reverts commit 699184b.

Revert "fixup warnings around the compiler"

c340732

This reverts commit f201752.

ICE when applying test to crate root

1864bf6

only discard items with #[test] on it when target is valid

9dd3cae

fixup name in diagnostics

97d4d21

address review comments

8f82478

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 4, 2025

Zalathar mentioned this pull request Dec 4, 2025

Implement blessing for tidy alphabetical check #149517

Open

Zalathar closed this Dec 4, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 9 pull requests #149603

Rollup of 9 pull requests #149603

matthiaskrgr commented Dec 3, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

bors commented Dec 3, 2025

Uh oh!

bors commented Dec 3, 2025

Uh oh!

rust-log-analyzer commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

bors commented Dec 3, 2025

Uh oh!

bors commented Dec 4, 2025

Uh oh!

rust-log-analyzer commented Dec 4, 2025

Uh oh!

bors commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Rollup of 9 pull requests #149603

Rollup of 9 pull requests #149603

Conversation

matthiaskrgr commented Dec 3, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

bors commented Dec 3, 2025

Uh oh!

bors commented Dec 3, 2025

Uh oh!

rust-log-analyzer commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

matthiaskrgr commented Dec 3, 2025

Uh oh!

bors commented Dec 3, 2025

Uh oh!

bors commented Dec 4, 2025

Uh oh!

rust-log-analyzer commented Dec 4, 2025

Uh oh!

bors commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

matthiaskrgr commented Dec 3, 2025 •

edited by rustbot

Loading